From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjT10-000111-DR for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:05:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjT0u-0004Ep-BJ for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:05:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjT0t-0004Eh-SF for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:05:40 -0500 Message-ID: <528DF70B.8060809@redhat.com> Date: Thu, 21 Nov 2013 13:05:31 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1384880863-10434-1-git-send-email-pbonzini@redhat.com> <1384880863-10434-14-git-send-email-pbonzini@redhat.com> <528DF1CC.7090001@kamp.de> <528DF33F.5000405@redhat.com> <528DF46E.5020902@kamp.de> In-Reply-To: <528DF46E.5020902@kamp.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 13/20] block/iscsi: use UNMAP to write zeroes if LBPRZ=1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Il 21/11/2013 12:54, Peter Lieven ha scritto: > What is the actual reason to add this tweak? The reason is that there are targets that implement UNMAP but not WRITE SAME. But I see what you mean---such a target could validly ignore the unaligned edges of the request. I guess it could be made to work, but unless someone really asks for it, let's drop the patch. Paolo