From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1VjTiT-0005bJ-BV
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:50:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1VjTiN-0000wZ-7k
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:50:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:24584)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1VjTiM-0000wT-UT
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:50:35 -0500
Message-ID: <528E018F.3010908@redhat.com>
Date: Thu, 21 Nov 2013 20:50:23 +0800
From: Fam Zheng <famz@redhat.com>
MIME-Version: 1.0
References: <1384933457-26953-1-git-send-email-famz@redhat.com>
	<1384933457-26953-6-git-send-email-famz@redhat.com>
	<20131121124158.GB7466@stefanha-thinkpad.redhat.com>
In-Reply-To: <20131121124158.GB7466@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 5/6] qemu-iotests: Force qcow2 in error
 path test in 048
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, WenchaoXia <xiawenc@linux.vnet.ibm.com>

On 2013=E5=B9=B411=E6=9C=8821=E6=97=A5 20:41, Stefan Hajnoczi wrote:
> On Wed, Nov 20, 2013 at 03:44:16PM +0800, Fam Zheng wrote:
>> The "raw" doesn't always work on certain file systems (e.g. tmpfs). Us=
e
>> qcow2 to make the allocation status explicit.
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>> ---
>>   tests/qemu-iotests/048 | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/qemu-iotests/048 b/tests/qemu-iotests/048
>> index 9def7fc..0fb5d2c 100755
>> --- a/tests/qemu-iotests/048
>> +++ b/tests/qemu-iotests/048
>> @@ -88,7 +88,13 @@ event =3D "read_aio"
>>   errno =3D "5"
>>   once =3D"off"
>>   EOF
>> -_make_test_img $size
>> +if [ "$IMGFMT" =3D "raw" ]; then
>> +    # For raw the allocation status for new image depends on file sys=
tem, force
>> +    # qcow2 in this case, since the tested code is in block layer
>> +    IMGFMT=3Dqcow2 _make_test_img $size | _filter_imgfmt
>
> If it can't be tested, skip the test.  Don't silently test something
> else.
>

OK. Do you think I should split the test? Since we don't have=20
conditional reference output.

Fam