From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
Richard Henderson <rth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-1.7 2/2] acpi-build: fix build on glib < 2.14
Date: Thu, 21 Nov 2013 15:16:46 +0100 [thread overview]
Message-ID: <528E15CE.108@redhat.com> (raw)
In-Reply-To: <20131121141639.GA8585@redhat.com>
Il 21/11/2013 15:16, Michael S. Tsirkin ha scritto:
> > This looks good, but is the below part necessary? It's ugly!
>
> Unfortunately yes. With old glib we don't know element size
> so we have to make all elements same size (1 byte).
>
> Without making change below change above will trigger assertions.
Ok, then please mention it in the commit message.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2013-11-21 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 12:17 [Qemu-devel] [PATCH for-1.7 1/2] acpi-build: fix build on glib < 2.22 Michael S. Tsirkin
2013-11-21 12:17 ` [Qemu-devel] [PATCH for-1.7 2/2] acpi-build: fix build on glib < 2.14 Michael S. Tsirkin
2013-11-21 13:54 ` Paolo Bonzini
2013-11-21 14:16 ` Michael S. Tsirkin
2013-11-21 14:16 ` Paolo Bonzini [this message]
2013-11-21 13:51 ` [Qemu-devel] [PATCH for-1.7 1/2] acpi-build: fix build on glib < 2.22 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528E15CE.108@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).