From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjV3x-00066N-P2 for qemu-devel@nongnu.org; Thu, 21 Nov 2013 09:17:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjV3r-0001hK-Qk for qemu-devel@nongnu.org; Thu, 21 Nov 2013 09:16:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjV3r-0001hC-3f for qemu-devel@nongnu.org; Thu, 21 Nov 2013 09:16:51 -0500 Message-ID: <528E15CE.108@redhat.com> Date: Thu, 21 Nov 2013 15:16:46 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1385036128-8753-1-git-send-email-mst@redhat.com> <1385036128-8753-2-git-send-email-mst@redhat.com> <528E1089.6090401@redhat.com> <20131121141639.GA8585@redhat.com> In-Reply-To: <20131121141639.GA8585@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-1.7 2/2] acpi-build: fix build on glib < 2.14 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Anthony Liguori , Richard Henderson Il 21/11/2013 15:16, Michael S. Tsirkin ha scritto: > > This looks good, but is the below part necessary? It's ugly! > > Unfortunately yes. With old glib we don't know element size > so we have to make all elements same size (1 byte). > > Without making change below change above will trigger assertions. Ok, then please mention it in the commit message. Reviewed-by: Paolo Bonzini Paolo