From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjVxW-0000YI-Jd for qemu-devel@nongnu.org; Thu, 21 Nov 2013 10:14:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjVxR-00029C-4R for qemu-devel@nongnu.org; Thu, 21 Nov 2013 10:14:22 -0500 Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:38832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjVxR-00028w-0t for qemu-devel@nongnu.org; Thu, 21 Nov 2013 10:14:17 -0500 Received: by mail-qc0-f180.google.com with SMTP id v2so165278qcr.39 for ; Thu, 21 Nov 2013 07:14:16 -0800 (PST) Sender: Paolo Bonzini Message-ID: <528E2343.7030008@redhat.com> Date: Thu, 21 Nov 2013 16:14:11 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1382440906-3852-1-git-send-email-otubo@linux.vnet.ibm.com> <5267E05A.1010601@linux.vnet.ibm.com> <20131030100439.GD11994@stefanha-thinkpad.redhat.com> In-Reply-To: <20131030100439.GD11994@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Paul Moore , coreyb@linux.vnet.ibm.com, qemu-devel , Anthony Liguori , Eduardo Otubo Il 30/10/2013 11:04, Stefan Hajnoczi ha scritto: > On Wed, Oct 23, 2013 at 12:42:34PM -0200, Eduardo Otubo wrote: >> >> >> On 10/22/2013 11:00 AM, Anthony Liguori wrote: >>> On Tue, Oct 22, 2013 at 12:21 PM, Eduardo Otubo >>> wrote: >>>> Inverting the way sandbox handles arguments, making possible to have no >>>> argument and still have '-sandbox on' enabled. >>>> >>>> Signed-off-by: Eduardo Otubo >>>> --- >>>> >>>> The option '-sandbox on' is now used by default by virt-test[0] -- it has been >>>> merged into the 'next' branch and will be available in the next release, >>>> meaning we have a back support for regression tests if anything breaks because >>>> of some missing system call not listed in the whitelist. >>>> >>>> This being said, I think it makes sense to have this option set to 'on' by >>>> default in the next Qemu version. It's been a while since no missing syscall is >>>> reported and at this point the whitelist seems to be pretty mature. >>>> >>>> [0] - https://github.com/autotest/virt-test/commit/50e1f7d47a94f4c770880cd8ec0f18365dcba714 >>> >>> This breaks hot_add of a network device that uses a script= argument, correct? >>> >>> If so, this cannot be made default. >> >> Anthony, I believe you're talking about the blacklist feature. This >> is the old whitelist that is already upstream and it does not block >> any network device to be hot plugged. > > The following fails to start here (the shell hangs and ps shows QEMU is > a process): > > qemu-system-x86_64 -sandbox on -enable-kvm -m 1024 -cpu host \ > -drive if=virtio,cache=none,file=test.img Easier-to-debug failures are another prerequisite for enabling the sandbox by default, I think. Paolo