From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjWp0-0000zz-KD for qemu-devel@nongnu.org; Thu, 21 Nov 2013 11:09:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjWou-0001O2-Kq for qemu-devel@nongnu.org; Thu, 21 Nov 2013 11:09:38 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56937 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjWou-0001Nu-Ec for qemu-devel@nongnu.org; Thu, 21 Nov 2013 11:09:32 -0500 Message-ID: <528E3037.8080005@suse.de> Date: Thu, 21 Nov 2013 17:09:27 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1385001528-12003-1-git-send-email-imammedo@redhat.com> <1385001528-12003-22-git-send-email-imammedo@redhat.com> <528D9EC8.5090307@cn.fujitsu.com> <528E14F8.2070204@suse.de> <20131121153453.1ce72399@nial.usersys.redhat.com> In-Reply-To: <20131121153453.1ce72399@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com, mst@redhat.com, hutao@cn.fujitsu.com, stefanb@linux.vnet.ibm.com, mjt@tls.msk.ru, armbru@redhat.com, qemu-devel@nongnu.org, vasilis.liaskovitis@profitbricks.com, quintela@redhat.com, chegu_vinod@hp.com, kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, marcel.a@redhat.com, lcapitulino@redhat.com, stefanha@redhat.com, Li Guang Am 21.11.2013 15:34, schrieb Igor Mammedov: > On Thu, 21 Nov 2013 15:13:12 +0100 > Andreas F=E4rber wrote: >> Am 21.11.2013 06:48, schrieb Li Guang: >>> Why not give the memory that not be hot-added a chance to be placed o= n >>> one memory slot? >> >> Seconded, I believe I requested that on the previous version already. > Because current initial memory allocation is a mess and this already > large series would become even more large and intrusive, so far series > it relatively not intrusive and self contained. >=20 > I believe re-factoring of initial memory to use Dimm devices should be > done later on top of infrastructure this series provides. My problem with that is that that would be a semantically incompatible modeling change. With your series we might have /machine/dimm.0/child[0] be the first hot-plugged memory and once such a refactoring is done, child[0] silently becomes -m and child[1] is the hot-added one. So if we know that we want/need to change the infrastructure, why not add a single patch (?) to allocate one additional object on the bus now? Unless we actually write the code, we won't know whether there are some incorrect hot-plug assumptions in the dimm code. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg