From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38814)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Vjcog-00022v-5R
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 17:33:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1VjcoW-0001K0-Sf
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 17:33:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56547)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1VjcoW-0001Jj-L3
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 17:33:32 -0500
Message-ID: <528E8A32.6040502@redhat.com>
Date: Thu, 21 Nov 2013 23:33:22 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1385072461-31317-1-git-send-email-lersek@redhat.com>
	<528E8896.70706@redhat.com>
In-Reply-To: <528E8896.70706@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than
 one flash drive
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: edk2-devel@lists.sourceforge.net, qemu-devel@nongnu.org, crobinso@redhat.com

On 11/21/13 23:26, Eric Blake wrote:
> On 11/21/2013 03:21 PM, Laszlo Ersek wrote:
>> This patch allows the user to usefully specify
>>
>>   -drive file=img_1,if=pflash,format=raw,readonly \
>>   -drive file=img_2,if=pflash,format=raw
>>
>> on the command line. The flash images will be mapped under 4G in their
>> reverse unit order -- that is, with their base addresses progressing
>> downwards, in increasing unit order.
>>
> 
>> +/* This function maps flash drives from 4G downward, in order of their unit
>> + * numbers. Addressing within one flash drive is of course not reversed.
>> + *
>> + * The drive with unit number 0 is mapped at the highest address, and it is
>> + * passed to pc_isa_bios_init(). Merging severral drives for isa-bios is not
> 
> s/severral/several/
> 

I may have meant "very severrrral" :)

(Will fix if patch is deemed worthy otherwise.)

Thanks!
Laszlo