From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52013)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vjn1g-00089i-Ah
	for qemu-devel@nongnu.org; Fri, 22 Nov 2013 04:27:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vjn1X-00065t-Tz
	for qemu-devel@nongnu.org; Fri, 22 Nov 2013 04:27:48 -0500
Received: from mail-ea0-x232.google.com ([2a00:1450:4013:c01::232]:33964)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vjn1X-00065e-NI
	for qemu-devel@nongnu.org; Fri, 22 Nov 2013 04:27:39 -0500
Received: by mail-ea0-f178.google.com with SMTP id d10so384565eaj.37
	for <qemu-devel@nongnu.org>; Fri, 22 Nov 2013 01:27:38 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <528F2385.50300@redhat.com>
Date: Fri, 22 Nov 2013 10:27:33 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1385072461-31317-1-git-send-email-lersek@redhat.com>
	<1385072499-31367-1-git-send-email-lersek@redhat.com>
In-Reply-To: <1385072499-31367-1-git-send-email-lersek@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [edk2] [edk2 PATCH] OvmfPkg: split the variable
 store to a separate file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: edk2-devel@lists.sourceforge.net
Cc: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org, crobinso@redhat.com

Il 21/11/2013 23:21, Laszlo Ersek ha scritto:
> Split the variable store off to a separate file when SPLIT_VARSTORE is
> defined.
> 
> Even in this case, the preexistent PCDs' values don't change. Qemu must
> take care of contiguously mapping NVVARSTORE.fd + OVMF.fd so that when
> concatenated they end exactly at 4GB.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

It's good that this is so easy to do.

The obvious question is, what happens if you only pass only OVMF.fd
(which would be less than 2MB in size, right)?

Also, I see a command line compatibility problem, especially if one
wants OVMF.fd to become the default firmware.  Then, having to specify
it again on the command line would be strange.

Paolo