From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjonE-00060O-83 for qemu-devel@nongnu.org; Fri, 22 Nov 2013 06:21:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vjon7-0004Z9-Q1 for qemu-devel@nongnu.org; Fri, 22 Nov 2013 06:21:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjon7-0004Z4-Hq for qemu-devel@nongnu.org; Fri, 22 Nov 2013 06:20:53 -0500 Message-ID: <528F3E0D.4040308@redhat.com> Date: Fri, 22 Nov 2013 12:20:45 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1385044625-31006-1-git-send-email-pl@kamp.de> <528F2EF8.9090509@redhat.com> <528F3C57.403@kamp.de> In-Reply-To: <528F3C57.403@kamp.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: qemu-devel@nongnu.org Il 22/11/2013 12:13, Peter Lieven ha scritto: >> I see where you come from, but I think the potential for this patch to >> break some working configuration (for some definition of working) is too >> high. Can you split out the fixes to the "fill in the blanks" logic? > > I can, but the number of sockets is logal to the parse function. Not sure why that matters, just make two patches instead of one. > What would you think is it okay to just send a warning about > the illegal config and drop the exit(1). Yes, that would be okay. Paolo