From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjxI9-00039r-EQ for qemu-devel@nongnu.org; Fri, 22 Nov 2013 15:25:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjxI3-0006Ip-3z for qemu-devel@nongnu.org; Fri, 22 Nov 2013 15:25:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjxI2-0006Hr-Rv for qemu-devel@nongnu.org; Fri, 22 Nov 2013 15:25:23 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAMKPLNW025309 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 22 Nov 2013 15:25:21 -0500 Message-ID: <528FBDAF.1030802@redhat.com> Date: Fri, 22 Nov 2013 13:25:19 -0700 From: Eric Blake MIME-Version: 1.0 References: <1385097894-1380-1-git-send-email-famz@redhat.com> <1385097894-1380-2-git-send-email-famz@redhat.com> In-Reply-To: <1385097894-1380-2-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WJjcckFTD4vadwjPXeaDDRF3EqCMeIwME" Subject: Re: [Qemu-devel] [PATCH v4 1/7] qapi: Add BlockOperationType enum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, hbrock@redhat.com, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WJjcckFTD4vadwjPXeaDDRF3EqCMeIwME Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/21/2013 10:24 PM, Fam Zheng wrote: > This adds the enum of all the operations that can be taken on a block > device. >=20 > Signed-off-by: Fam Zheng > --- > qapi-schema.json | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > =20 > ## > +# @BlockOperationType > +# Type of a block operation. > +# > +# Since: 1.8 It might be worth adding a bit more docs, as in one line per enum value with a cross-reference to the command(s) that can trigger that operation. Something like: @backup: See the 'drive-backup' command. @change: See the 'change' command. This is especially true if we later add new block ops later than 1.8, so such additions can have the useful '(since 1.9)' notation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WJjcckFTD4vadwjPXeaDDRF3EqCMeIwME Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSj72vAAoJEKeha0olJ0NqBk8H/3gwORxKUZ1kz7VTeoAhNiNK o/4FCmjGYLR5+mzjEr6vS4qwVhVjJ9YVt5XeH+mO+NOMCeTrwD32/yDZPfo+49jK lDht/rGkd1fhkvaqj8B4OBQ4TLpQvq3CEXRmgw2hmN9/Stpycf0VV76+tT5yOSJi bcIxlTBmURlLZo8UkePxViGCZiCT4Lt0uHh7EIsxCyzADQMkacEH63zDNhJIRX+I MKwQiwjFP8hXFKiqXmuaH58gKBrl0/gamXdCQZxIaAUhhSva6pOuRr7dIwzjhEiW kKWFx8l02C5hE4M8v2huzcPrszm/g6g85H1oXfUPOPPqR7jP38DbunX24XvLyJY= =HUJp -----END PGP SIGNATURE----- --WJjcckFTD4vadwjPXeaDDRF3EqCMeIwME--