From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjyYJ-0008NG-6I for qemu-devel@nongnu.org; Fri, 22 Nov 2013 16:46:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjyYD-0003So-3K for qemu-devel@nongnu.org; Fri, 22 Nov 2013 16:46:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjyYC-0003Si-RF for qemu-devel@nongnu.org; Fri, 22 Nov 2013 16:46:09 -0500 Message-ID: <528FD096.7070501@redhat.com> Date: Fri, 22 Nov 2013 22:45:58 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1385072461-31317-1-git-send-email-lersek@redhat.com> <1385072499-31367-1-git-send-email-lersek@redhat.com> <528FA5C3.9070809@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jordan Justen Cc: "edk2-devel@lists.sourceforge.net" , qemu-devel , Cole Robinson On 11/22/13 21:51, Jordan Justen wrote: > Many of these scenarios were discussed in the past on qemu-devel, but > a single -pflash was the only thing that stuck. This has made me just > focus on making the single file pflash work. I almost forgot to reflect on this -- I'm extremely grateful to you that you implemented the flash driver. I tried to be as non-intrusive in my OVMF patch as possible. Keeping the PCD values and the original memory layout was crucial -- I wanted the driver to continue working as-is. Everything else (the qemu patch, for example) came from that. In fact I wrote the OVMF patch first, and then said "let's see how we can accommodate this in qemu". (Sorry about answering twice.) Laszlo