From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
QEMU <qemu-devel@nongnu.org>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 2/2] Add -mem-shared option
Date: Fri, 29 Nov 2019 18:46:12 +0100 [thread overview]
Message-ID: <528bb183-3d44-e541-8765-9c0e01f23157@redhat.com> (raw)
In-Reply-To: <20191129131652.6683b769@redhat.com>
On 29/11/19 13:16, Igor Mammedov wrote:
> As for "-m", I'd make it just an alias that translates
> -m/mem-path/mem-prealloc
I think we should just deprecate -mem-path/-mem-prealloc in 5.0. CCing
Thomas as mister deprecation. :)
> combination to appropriate '-object' for '-machine memdev' consumption.
> That should cover compat purposes for old machines and the rest of
> -m options (maxmem/slots) would be aliased to appropriate machine options.
>
> That will allow us to get rid of ad-hoc '-m' parser. After that it would
> be possible to deprecate '-m' in favor of machine properties, but that
> probably will get quite a push back so unless I find compelling reason
> to do it I won't care much as '-m' would be a lightweight shim over
> machine properties.
Well, deprecation and ultimately removal is always a long path.
However, I understand your plan better now and having "-machine memdev"
makes sense if you want to also move/alias "-m maxmem"/"-m slots" from
"-m" to "-machine".
So ultimately you'd have two ways of configuring memory:
- -m N,maxmem=P,slots=Q
" -machine memdev=M,maxmem=P,slots=Q
Paolo
next prev parent reply other threads:[~2019-11-29 17:49 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 14:15 [PATCH 0/2] RFC: add -mem-shared option Marc-André Lureau
2019-11-28 14:15 ` [PATCH 1/2] memfd: add qemu_memfd_open() Marc-André Lureau
2019-11-28 14:15 ` [PATCH 2/2] Add -mem-shared option Marc-André Lureau
2019-11-28 16:14 ` Eduardo Habkost
2019-11-28 16:28 ` Igor Mammedov
2019-11-28 20:31 ` Marc-André Lureau
2019-11-29 10:07 ` Igor Mammedov
2019-11-29 10:11 ` Paolo Bonzini
2019-11-29 12:01 ` Markus Armbruster
2019-11-29 20:31 ` Eduardo Habkost
2019-11-29 12:16 ` Igor Mammedov
2019-11-29 17:46 ` Paolo Bonzini [this message]
2019-12-02 7:39 ` Igor Mammedov
2019-12-02 21:00 ` Eduardo Habkost
2019-12-03 8:56 ` Thomas Huth
2019-12-03 14:43 ` Igor Mammedov
2019-12-09 20:58 ` Eduardo Habkost
2019-12-10 10:34 ` Markus Armbruster
2019-12-10 13:09 ` Igor Mammedov
2019-12-03 21:34 ` Eduardo Habkost
2019-11-28 16:10 ` [PATCH 0/2] RFC: add " Eduardo Habkost
2019-11-29 9:18 ` Igor Mammedov
2019-11-29 9:31 ` Paolo Bonzini
2019-11-29 10:23 ` Igor Mammedov
2019-11-29 11:21 ` Paolo Bonzini
2019-11-29 20:21 ` Eduardo Habkost
2019-12-01 15:40 ` Marc-André Lureau
2019-12-01 18:03 ` Paolo Bonzini
2019-11-28 16:59 ` Dr. David Alan Gilbert
2019-11-29 9:23 ` Igor Mammedov
2019-12-13 11:39 ` Stefan Hajnoczi
2019-12-13 13:12 ` Igor Mammedov
2019-11-29 4:37 ` no-reply
2019-11-29 5:34 ` no-reply
2019-11-29 7:02 ` Gerd Hoffmann
2019-11-29 7:30 ` Marc-André Lureau
2019-11-29 9:27 ` Daniel P. Berrangé
2019-11-29 9:31 ` Marc-André Lureau
2019-11-29 9:42 ` Daniel P. Berrangé
2019-11-29 9:45 ` Marc-André Lureau
2019-11-29 11:44 ` Gerd Hoffmann
2019-11-29 9:33 ` Paolo Bonzini
2019-11-29 9:39 ` Daniel P. Berrangé
2019-11-29 9:52 ` Paolo Bonzini
2019-11-29 10:13 ` Igor Mammedov
2019-11-29 11:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528bb183-3d44-e541-8765-9c0e01f23157@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).