From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VkHVv-0006Ro-36
	for qemu-devel@nongnu.org; Sat, 23 Nov 2013 13:01:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VkHVp-0008DY-8x
	for qemu-devel@nongnu.org; Sat, 23 Nov 2013 13:01:03 -0500
Received: from cantor2.suse.de ([195.135.220.15]:39218 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VkHVp-0008DO-27
	for qemu-devel@nongnu.org; Sat, 23 Nov 2013 13:00:57 -0500
Message-ID: <5290ED53.5020908@suse.de>
Date: Sat, 23 Nov 2013 19:00:51 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1385133359-13770-1-git-send-email-edgar.iglesias@gmail.com>	<1385133359-13770-7-git-send-email-edgar.iglesias@gmail.com>	<CAFEAcA9jmbDkN+hunH24yaTRzxWDbKAzig+SRrix4d8Zd6spPg@mail.gmail.com>
	<CAJy5ezrpztq_hU=QHHVY2C5GcvoB-TEQ4COCrFqX873Zweap3Q@mail.gmail.com>
In-Reply-To: <CAJy5ezrpztq_hU=QHHVY2C5GcvoB-TEQ4COCrFqX873Zweap3Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel <qemu-devel@nongnu.org>

Am 22.11.2013 17:02, schrieb Edgar E. Iglesias:
> Hi, no I actually had it in cpustate first but had to do env-get-cpu al=
l
> over so i moved it to env. Iiuc env-get-cpu involves a dyn typecheck.

No, it doesn't any more, it's just a pointer offset.

Andreas

> I havent meassured the perf impact though.
>=20
> Sorry for phone email...
>=20
> Cheers
>=20
> ---
> Sent from my phone
>=20
> On Nov 22, 2013 4:51 PM, "Peter Maydell" <peter.maydell@linaro.org
> <mailto:peter.maydell@linaro.org>> wrote:
>=20
>     On 22 November 2013 15:15,  <edgar.iglesias@gmail.com
>     <mailto:edgar.iglesias@gmail.com>> wrote:
>     > @@ -176,6 +176,9 @@ typedef struct CPUWatchpoint {
>     >      sigjmp_buf jmp_env;                                         =
=20
>           \
>     >      int exception_index;                                       =20
>            \
>     >                                                                 =20
>            \
>     > +    /* Per CPU address-space.  */                               =
=20
>           \
>     > +    AddressSpace *as;                                           =
=20
>           \
>     > +                                                               =20
>            \
>=20
>     Does this really have to live in the env struct rather than
>     CPUState ?
>=20
>     thanks
>     -- PMM
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg