qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH for 1.7] configure: make --iasl option actually work
Date: Sun, 24 Nov 2013 16:14:50 +0100	[thread overview]
Message-ID: <529217EA.1000302@weilnetz.de> (raw)
In-Reply-To: <20131124095210.GA30741@redhat.com>

Am 24.11.2013 10:52, schrieb Michael S. Tsirkin:
> --iasl option was added to CC option parsing section by mistake,
> it's not effective there and attempts to use cause
> an 'unknown option' error.
>
> Fix this up.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index f6d5ccd..0592ba7 100755
> --- a/configure
> +++ b/configure
> @@ -272,8 +272,6 @@ for opt do
>    ;;
>    --cxx=*) CXX="$optarg"
>    ;;
> -  --iasl=*) iasl="$optarg"
> -  ;;
>    --source-path=*) source_path="$optarg"
>    ;;
>    --cpu=*) cpu="$optarg"
> @@ -649,6 +647,8 @@ for opt do
>    ;;
>    --cxx=*)
>    ;;
> +  --iasl=*) iasl="$optarg"
> +  ;;
>    --objcc=*) objcc="$optarg"
>    ;;
>    --make=*) make="$optarg"

Reviewed-by: Stefan Weil <sw@weilnetz.de>

This is a trivial bug fix, so maybe it should be committed for QEMU 1.7.
Therefore I changed the subject of the e-mail to include 'for 1.7'.

Regards,
Stefan

      parent reply	other threads:[~2013-11-24 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-24  9:52 [Qemu-devel] [PATCH] configure: make --iasl option actually work Michael S. Tsirkin
2013-11-24 12:54 ` Marcel Apfelbaum
2013-11-24 15:14 ` Stefan Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529217EA.1000302@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=aliguori@amazon.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).