From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VktDL-0000bK-Pn for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:16:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VktDF-00056V-5x for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:16:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VktDE-00056P-ST for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:16:17 -0500 Message-ID: <52932366.2060500@redhat.com> Date: Mon, 25 Nov 2013 11:16:06 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1385124001-3576-1-git-send-email-pbonzini@redhat.com> <1385124001-3576-6-git-send-email-pbonzini@redhat.com> <5293213F.30502@kamp.de> In-Reply-To: <5293213F.30502@kamp.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 05/19] block: handle ENOTSUP from discard in generic code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com Il 25/11/2013 11:06, Peter Lieven ha scritto: > wouldn't it make sense to return -ENOTSUP in other drivers a well if the > operation is not supported and not return 0? Yes; patches are welcome. :) (I have a patch for block/iscsi.c that handles LBPU=1/LBPWS=0, and one of the things it does is "return 0" -> "return -ENOTSUP" for consistency between iscsi_co_discard and iscsi_co_write_zeroes). Paolo