From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VktTW-0000wc-J3 for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:33:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VktTP-0001Ug-6b for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:33:06 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:45890 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VktTO-0001UA-SW for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:32:59 -0500 Message-ID: <5293276F.7030902@kamp.de> Date: Mon, 25 Nov 2013 11:33:19 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1385124001-3576-1-git-send-email-pbonzini@redhat.com> <1385124001-3576-10-git-send-email-pbonzini@redhat.com> In-Reply-To: <1385124001-3576-10-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 09/19] block drivers: expose requirement for write same alignment from formats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com On 22.11.2013 13:39, Paolo Bonzini wrote: > This will let misaligned but large requests use zero clusters. This > is important because the cluster size is not guest visible. > > Signed-off-by: Paolo Bonzini > --- > block/qcow2.c | 1 + > block/qed.c | 1 + > block/vmdk.c | 4 ++++ > 3 files changed, 6 insertions(+) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 1542750..81c4dad 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -718,6 +718,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags, > } > > qemu_opts_del(opts); > + bs->bl.write_zeroes_alignment = s->cluster_sectors; please add a patch that sets bs->bl.discard_alignment = s->cluster_sectors; > > if (s->use_lazy_refcounts && s->qcow_version < 3) { > error_setg(errp, "Lazy refcounts require a qcow2 image with at least " > diff --git a/block/qed.c b/block/qed.c > index 59516a5..450a1fa 100644 > --- a/block/qed.c > +++ b/block/qed.c > @@ -495,6 +495,7 @@ static int bdrv_qed_open(BlockDriverState *bs, QDict *options, int flags, > } > } > > + bs->bl.write_zeroes_alignment = s->header.cluster_size >> BDRV_SECTOR_BITS; > s->need_check_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, > qed_need_check_timer_cb, s); > > diff --git a/block/vmdk.c b/block/vmdk.c > index 6555663..63ea7ff 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -428,6 +428,10 @@ static int vmdk_add_extent(BlockDriverState *bs, > extent->l2_size = l2_size; > extent->cluster_sectors = flat ? sectors : cluster_sectors; > > + if (!flat) { > + bs->bl.write_zeroes_alignment = > + MAX(bs->bl.write_zeroes_alignment, cluster_sectors); > + } > if (s->num_extents > 1) { > extent->end_sector = (*(extent - 1)).end_sector + extent->sectors; > } else { > Reviewed-by: Peter Lieven