From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkvjQ-0007MZ-S1 for qemu-devel@nongnu.org; Mon, 25 Nov 2013 07:57:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkvjK-0004SP-JZ for qemu-devel@nongnu.org; Mon, 25 Nov 2013 07:57:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkvjK-0004SK-Ai for qemu-devel@nongnu.org; Mon, 25 Nov 2013 07:57:34 -0500 Message-ID: <5293492D.3050607@redhat.com> Date: Mon, 25 Nov 2013 13:57:17 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1385001528-12003-1-git-send-email-imammedo@redhat.com> <1385001528-12003-9-git-send-email-imammedo@redhat.com> In-Reply-To: <1385001528-12003-9-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/27] dimm: implement dimm device abstraction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com, mst@redhat.com, mjt@tls.msk.ru, stefanb@linux.vnet.ibm.com, stefanha@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, vasilis.liaskovitis@profitbricks.com, quintela@redhat.com, chegu_vinod@hp.com, kraxel@redhat.com, aliguori@amazon.com, hutao@cn.fujitsu.com, marcel.a@redhat.com, lcapitulino@redhat.com, afaerber@suse.de Il 21/11/2013 03:38, Igor Mammedov ha scritto: > +static void dimm_initfn(Object *obj) > +{ > + object_property_add(obj, "memdev", "string", dimm_get_memdev, > + dimm_set_memdev, NULL, NULL, NULL); Perhaps, instead of relying on memory_region_owner, you could have separate pointers for the MemoryBackend* and MemoryRegion*. Then this property could be a link type (it looks like a link, and quacks like a link). Paolo > + object_property_add(obj, "size", "int", dimm_get_size, > + NULL, NULL, NULL, NULL); > +} > +