From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52583)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VkwRI-0007Ok-I4
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 08:43:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VkwR9-00023m-U8
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 08:43:00 -0500
Received: from mail-qe0-x230.google.com ([2607:f8b0:400d:c02::230]:62526)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VkwR9-00023h-OZ
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 08:42:51 -0500
Received: by mail-qe0-f48.google.com with SMTP id gc15so3803128qeb.7
	for <qemu-devel@nongnu.org>; Mon, 25 Nov 2013 05:42:51 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <529353D4.1060702@redhat.com>
Date: Mon, 25 Nov 2013 14:42:44 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1385001528-12003-1-git-send-email-imammedo@redhat.com>
	<1385001528-12003-24-git-send-email-imammedo@redhat.com>
In-Reply-To: <1385001528-12003-24-git-send-email-imammedo@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory
	hotplug interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@amazon.com, stefanb@linux.vnet.ibm.com, armbru@redhat.com, mst@redhat.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, vasilis.liaskovitis@profitbricks.com, quintela@redhat.com, kraxel@redhat.com, stefanha@redhat.com, hutao@cn.fujitsu.com, marcel.a@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com, afaerber@suse.de

Il 21/11/2013 03:38, Igor Mammedov ha scritto:
> +                // 64-bit math: MAX = MIN + LEN - 1
> +                Add(MINL, LENL, MAXL)
> +                Add(MINH, LENH, MAXH)
> +                If (Or(LLess(MAXL, MINL), LLess(MAXL, LENL))) {

The Or is not necessary, LLess(MAXL, MINL) is enough.

> +                    Add(MAXH, 1, MAXH)

One?  (Just for consistency, iasl does it already).

> +                }

> +                // Ignore (MAXL == 0 & MAXH == 0) case
> +                If (LEqual(MAXL, Zero)) {
> +                    Subtract(MAXH, One, MAXH)
> +                    Store(0xFFFFFFFF, MAXL)
> +                } Else {
> +                    Subtract(MAXL, One, MAXL)
> +                }
> +

Why not this:

                   If (LLess(MAXL, One)) {
                       Subtract(MAXH, One, MAXH)
                   }
                   Subtract(MAXL, One, MAXL)

Paolo