From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl2kC-0000Hl-3J for qemu-devel@nongnu.org; Mon, 25 Nov 2013 15:27:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vl2k7-0003xM-B1 for qemu-devel@nongnu.org; Mon, 25 Nov 2013 15:26:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl2k7-0003xI-2R for qemu-devel@nongnu.org; Mon, 25 Nov 2013 15:26:51 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAPKQo2T028239 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 Nov 2013 15:26:50 -0500 Message-ID: <5293B287.5010201@redhat.com> Date: Tue, 26 Nov 2013 06:26:47 +1000 From: Richard Henderson MIME-Version: 1.0 References: <1385379990-32093-1-git-send-email-mst@redhat.com> <1385379990-32093-5-git-send-email-mst@redhat.com> In-Reply-To: <1385379990-32093-5-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL for-1.7 v2 4/6] acpi-build: fix build on glib < 2.14 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Paolo Bonzini On 11/25/2013 09:48 PM, Michael S. Tsirkin wrote: > +#if GLIB_CHECK_VERSION(2, 14, 0) > + assert(g_array_get_element_size(table) == 1); > +#endif https://developer.gnome.org/glib/2.28/glib-Arrays.html#g-array-get-element-size says "Since 2.22", not 2.14. r~