From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54839)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Vl7vn-0000Mt-Er
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 20:59:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Vl7vh-0006dn-G9
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 20:59:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50046)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Vl7vh-0006df-82
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 20:59:09 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAQ1x6ZE003543
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 25 Nov 2013 20:59:07 -0500
Message-ID: <52940062.6050306@redhat.com>
Date: Tue, 26 Nov 2013 09:58:58 +0800
From: Fam Zheng <famz@redhat.com>
MIME-Version: 1.0
References: <1385097894-1380-1-git-send-email-famz@redhat.com>
	<1385097894-1380-2-git-send-email-famz@redhat.com>
	<20131125112647.GH3009@dhcp-200-207.str.redhat.com>
In-Reply-To: <20131125112647.GH3009@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 1/7] qapi: Add BlockOperationType enum
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com

On 2013=E5=B9=B411=E6=9C=8825=E6=97=A5 19:26, Kevin Wolf wrote:
> Am 22.11.2013 um 06:24 hat Fam Zheng geschrieben:
>> This adds the enum of all the operations that can be taken on a block
>> device.
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> Okay, so now I've read the whole series and I still couldn't solve this
> mystery: Why is this a QAPI type and not some internal enum?
>
The logic is becoming complicated, I think even more rules will come=20
with Quorum and BlockBackend, etc. By then we probably will have to add=20
an interface to query the blockers, so user knows what operation is=20
possible and what is not, without trial and error.

Eric, any ideas?

Fam