From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org,
rjones@redhat.com, imain@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 3/7] block: Replace in_use with operation blocker
Date: Tue, 26 Nov 2013 10:18:14 +0800 [thread overview]
Message-ID: <529404E6.3000904@redhat.com> (raw)
In-Reply-To: <529384B2.7010109@redhat.com>
On 2013年11月26日 01:11, Paolo Bonzini wrote:
> Il 22/11/2013 06:24, Fam Zheng ha scritto:
>> @@ -41,13 +41,11 @@ void *block_job_create(const BlockJobDriver *driver, BlockDriverState *bs,
>> {
>> BlockJob *job;
>>
>> - if (bs->job || bdrv_in_use(bs)) {
>> + if (bs->job) {
>> error_set(errp, QERR_DEVICE_IN_USE, bdrv_get_device_name(bs));
>> return NULL;
>> }
>> bdrv_ref(bs);
>
> Why is this check disappearing?
>
Because this patch is moving this check to callers, and changing it to
op blocker check.
Fam
next prev parent reply other threads:[~2013-11-26 2:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 5:24 [Qemu-devel] [PATCH v4 0/7] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Fam Zheng
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 1/7] qapi: Add BlockOperationType enum Fam Zheng
2013-11-22 20:25 ` Eric Blake
2013-11-25 11:26 ` Kevin Wolf
2013-11-26 1:58 ` Fam Zheng
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState Fam Zheng
2013-11-22 16:20 ` Stefan Hajnoczi
2013-11-25 10:07 ` Kevin Wolf
2013-11-25 10:30 ` Kevin Wolf
2013-11-25 17:13 ` Paolo Bonzini
2013-11-26 2:07 ` Fam Zheng
2013-11-26 9:22 ` Paolo Bonzini
2013-11-26 10:19 ` Fam Zheng
2013-11-26 10:25 ` Paolo Bonzini
2013-11-26 10:31 ` Fam Zheng
2013-11-26 10:41 ` Paolo Bonzini
2013-11-26 11:05 ` Fam Zheng
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 3/7] block: Replace in_use with operation blocker Fam Zheng
2013-11-25 17:11 ` Paolo Bonzini
2013-11-26 2:18 ` Fam Zheng [this message]
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 4/7] block: Add checks of blocker in block operations Fam Zheng
2013-11-25 17:15 ` Paolo Bonzini
2013-11-26 2:10 ` Fam Zheng
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 5/7] block: Parse "backing" option to reference existing BDS Fam Zheng
2013-11-25 11:10 ` Kevin Wolf
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 6/7] qmp: add command 'blockdev-backup' Fam Zheng
2013-11-22 20:46 ` Eric Blake
2013-11-25 11:17 ` Kevin Wolf
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 7/7] block: Allow backup on referenced named BlockDriverState Fam Zheng
2013-11-25 11:23 ` Kevin Wolf
2013-11-26 3:06 ` Fam Zheng
2013-11-26 11:02 ` Kevin Wolf
2013-11-22 16:58 ` [Qemu-devel] [PATCH v4 0/7] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Stefan Hajnoczi
2013-11-23 11:33 ` Fam Zheng
2013-11-25 9:29 ` Kevin Wolf
2013-11-25 16:48 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529404E6.3000904@redhat.com \
--to=famz@redhat.com \
--cc=hbrock@redhat.com \
--cc=imain@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).