From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlEZd-0001aP-RN for qemu-devel@nongnu.org; Tue, 26 Nov 2013 04:04:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlEZX-0002fp-Sj for qemu-devel@nongnu.org; Tue, 26 Nov 2013 04:04:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlEZX-0002fb-Kg for qemu-devel@nongnu.org; Tue, 26 Nov 2013 04:04:43 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAQ94g7K014632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Nov 2013 04:04:42 -0500 Message-ID: <52946428.2050900@redhat.com> Date: Tue, 26 Nov 2013 10:04:40 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1385401393-14291-1-git-send-email-pbonzini@redhat.com> <20131125210510.GL12689@redhat.com> In-Reply-To: <20131125210510.GL12689@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH rebased for-1.8] i386: pc: align gpa<->hpa on 1GB boundary (v6) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Marcelo Tosatti , qemu-devel@nongnu.org Il 25/11/2013 22:05, Michael S. Tsirkin ha scritto: >> > Signed-off-by: Marcelo Tosatti >> > [Reorganize code, keep same logic. - Paolo] >> > Signed-off-by: Paolo Bonzini > BTW how about a unit-test for this? > Can be something along the lines of the acpi tests: > run BIOS, probe what it reported. > No, it can't because the change is not guest visible. It is not enabled for machine types <=1.8 due to migration compatibility (the migration stream uses offsets within the RAM block, and these change), but there is no difference from the guest point of view. Paolo