From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org,
rjones@redhat.com, imain@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState
Date: Tue, 26 Nov 2013 10:22:07 +0100 [thread overview]
Message-ID: <5294683F.8090004@redhat.com> (raw)
In-Reply-To: <52940262.2090406@redhat.com>
Il 26/11/2013 03:07, Fam Zheng ha scritto:
>>>
>>> +void bdrv_op_unblock(BlockDriverState *bs, BlockOpType op, Error
>>> *reason)
>>
>> What about making BlockOpType a bitmask, and having bdrv_op_{,un}block
>> take multiple ORed BlockOpTypes?
>>
>> bdrv_op_{,un}block_all then are not necessary, you only need a
>> BLOCK_OPERATION_ALL value.
>>
>
> Bitmap is not enough, at least it should be an array. For example when
> we enable multiple block jobs, there're two stoppers for drive_del, right?
I said bitmask, not bitmap. :)
So that you can add the same Error to multiple items of the array with a
single bdrv_op_block call (by ORing them into the second parameter).
Paolo
next prev parent reply other threads:[~2013-11-26 9:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 5:24 [Qemu-devel] [PATCH v4 0/7] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Fam Zheng
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 1/7] qapi: Add BlockOperationType enum Fam Zheng
2013-11-22 20:25 ` Eric Blake
2013-11-25 11:26 ` Kevin Wolf
2013-11-26 1:58 ` Fam Zheng
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState Fam Zheng
2013-11-22 16:20 ` Stefan Hajnoczi
2013-11-25 10:07 ` Kevin Wolf
2013-11-25 10:30 ` Kevin Wolf
2013-11-25 17:13 ` Paolo Bonzini
2013-11-26 2:07 ` Fam Zheng
2013-11-26 9:22 ` Paolo Bonzini [this message]
2013-11-26 10:19 ` Fam Zheng
2013-11-26 10:25 ` Paolo Bonzini
2013-11-26 10:31 ` Fam Zheng
2013-11-26 10:41 ` Paolo Bonzini
2013-11-26 11:05 ` Fam Zheng
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 3/7] block: Replace in_use with operation blocker Fam Zheng
2013-11-25 17:11 ` Paolo Bonzini
2013-11-26 2:18 ` Fam Zheng
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 4/7] block: Add checks of blocker in block operations Fam Zheng
2013-11-25 17:15 ` Paolo Bonzini
2013-11-26 2:10 ` Fam Zheng
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 5/7] block: Parse "backing" option to reference existing BDS Fam Zheng
2013-11-25 11:10 ` Kevin Wolf
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 6/7] qmp: add command 'blockdev-backup' Fam Zheng
2013-11-22 20:46 ` Eric Blake
2013-11-25 11:17 ` Kevin Wolf
2013-11-22 5:24 ` [Qemu-devel] [PATCH v4 7/7] block: Allow backup on referenced named BlockDriverState Fam Zheng
2013-11-25 11:23 ` Kevin Wolf
2013-11-26 3:06 ` Fam Zheng
2013-11-26 11:02 ` Kevin Wolf
2013-11-22 16:58 ` [Qemu-devel] [PATCH v4 0/7] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Stefan Hajnoczi
2013-11-23 11:33 ` Fam Zheng
2013-11-25 9:29 ` Kevin Wolf
2013-11-25 16:48 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5294683F.8090004@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=hbrock@redhat.com \
--cc=imain@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).