From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36224)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VlFqc-0005pV-O9
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 05:26:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VlFqW-0004Qa-Gy
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 05:26:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55383)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VlFqW-0004QR-9W
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 05:26:20 -0500
Message-ID: <52947734.80207@redhat.com>
Date: Tue, 26 Nov 2013 11:25:56 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1385097894-1380-1-git-send-email-famz@redhat.com>
	<1385097894-1380-3-git-send-email-famz@redhat.com>
	<52938532.1080803@redhat.com> <52940262.2090406@redhat.com>
	<5294683F.8090004@redhat.com>
	<CABgc4wRzJhsN-LyxXzbSWWnWiic4GZUBSiP=-tBLp9K=v0q_Ug@mail.gmail.com>
In-Reply-To: <CABgc4wRzJhsN-LyxXzbSWWnWiic4GZUBSiP=-tBLp9K=v0q_Ug@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to
	BlockDriverState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famcool@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, hbrock@redhat.com, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, rjones@redhat.com, imain@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>

Il 26/11/2013 11:19, Fam Zheng ha scritto:
>> So that you can add the same Error to multiple items of the array with a
>> single bdrv_op_block call (by ORing them into the second parameter).
> 
> What data type to contain this? I'm not sure 64 is enough in long term...

I would just use an uint64_t, I think you have ~20 operations now.
There is still quite some breathing room.

Paolo