From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <claudio.fontana@linaro.org>) id 1VlHEy-0004Hr-Rj
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 06:55:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <claudio.fontana@linaro.org>) id 1VlHEr-00010O-48
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 06:55:40 -0500
Received: from mail-ea0-f173.google.com ([209.85.215.173]:57388)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <claudio.fontana@linaro.org>) id 1VlHEq-0000zw-Ub
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 06:55:33 -0500
Received: by mail-ea0-f173.google.com with SMTP id g15so3430523eak.4
	for <qemu-devel@nongnu.org>; Tue, 26 Nov 2013 03:55:31 -0800 (PST)
Message-ID: <52948C73.5010703@linaro.org>
Date: Tue, 26 Nov 2013 12:56:35 +0100
From: Claudio Fontana <claudio.fontana@linaro.org>
MIME-Version: 1.0
References: <1380242934-20953-1-git-send-email-agraf@suse.de>
	<1380242934-20953-30-git-send-email-agraf@suse.de>
	<5245DFB4.6050500@twiddle.net>
In-Reply-To: <5245DFB4.6050500@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction
	emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Dirk Mueller <dmueller@suse.de>, Laurent Desnogues <laurent.desnogues@gmail.com>, Christoffer Dall <christoffer.dall@linaro.org>

On 09/27/2013 09:42 PM, Richard Henderson wrote:
> On 09/26/2013 05:48 PM, Alexander Graf wrote:
>> +    if (setflags) {
>> +        tcg_dst = cpu_reg(dest);
>> +    } else {
>> +        tcg_dst = cpu_reg_sp(dest);
>> +    }
> 
> Never sp for logicals.

This should be ok in my view, the manual explicitly shows in the pseudocode:

if d == 31 && !setflags then
 SP[] = result;
else
 X[d] = result;

Claudio

> 
>> +            handle_orri(s, insn);
> 
> And yet again, a better function name.
> 
> 
> r~
>