From: Laszlo Ersek <lersek@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] piix: fix 32bit pci hole
Date: Wed, 27 Nov 2013 12:48:27 +0100 [thread overview]
Message-ID: <5295DC0B.2000000@redhat.com> (raw)
In-Reply-To: <1385534761.13867.9.camel@nilsson.home.kraxel.org>
On 11/27/13 07:46, Gerd Hoffmann wrote:
>
>>> + i440fx->pci_info.w32.begin = ram_size;
>
>> But this patch also obliterates the high bound, 0xe0000000, which can
>> lead to:
>> - w32.end - w32.begin <= 512M, or
>> - a special case of the former, w32.end < w32.begin.
>
> ram_size is not the total amount of memory, it is low memory only.
I tried to check for that when I sent the email, and I couldn't see
where this is enforced. See:
pc_init1() [hw/i386/pc_piix.c]
i440fx_init() [hw/pci-host/piix.c]
pc_init1() receives the full RAM size in "args->ram_size". It uses this
value to compute "above_4g_mem_size" and "below_4g_mem_size", for example.
pc_init1() passes "args->ram_size" unchanged to i440fx_init(), as 7th
argument.
The 7th parameter of i440fx_init() is called "ram_size". Therefore it
will hold the whole RAM size.
Thanks
Laszlo
next prev parent reply other threads:[~2013-11-27 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 16:16 [Qemu-devel] [PATCH] piix: fix 32bit pci hole Gerd Hoffmann
2013-11-26 21:33 ` Laszlo Ersek
2013-11-27 6:46 ` Gerd Hoffmann
2013-11-27 11:48 ` Laszlo Ersek [this message]
2013-11-26 23:36 ` Jordan Justen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295DC0B.2000000@redhat.com \
--to=lersek@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).