From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50287)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vln5p-0001EG-Pl
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 16:56:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vln5h-0007w4-CO
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 16:56:21 -0500
Received: from mail-ie0-x22b.google.com ([2607:f8b0:4001:c03::22b]:64129)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vln5h-0007vQ-6a
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 16:56:13 -0500
Received: by mail-ie0-f171.google.com with SMTP id ar20so13282708iec.30
	for <qemu-devel@nongnu.org>; Wed, 27 Nov 2013 13:56:12 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52966A75.9070503@twiddle.net>
Date: Thu, 28 Nov 2013 10:56:05 +1300
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1380242934-20953-1-git-send-email-agraf@suse.de>	<1380242934-20953-30-git-send-email-agraf@suse.de>	<5245DFB4.6050500@twiddle.net>
	<52948C73.5010703@linaro.org>
In-Reply-To: <52948C73.5010703@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction
	emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Claudio Fontana <claudio.fontana@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Dirk Mueller <dmueller@suse.de>, Laurent Desnogues <laurent.desnogues@gmail.com>, Christoffer Dall <christoffer.dall@linaro.org>

On 11/27/2013 12:56 AM, Claudio Fontana wrote:
> On 09/27/2013 09:42 PM, Richard Henderson wrote:
>> On 09/26/2013 05:48 PM, Alexander Graf wrote:
>>> +    if (setflags) {
>>> +        tcg_dst = cpu_reg(dest);
>>> +    } else {
>>> +        tcg_dst = cpu_reg_sp(dest);
>>> +    }
>>
>> Never sp for logicals.
> 
> This should be ok in my view, the manual explicitly shows in the pseudocode:
> 
> if d == 31 && !setflags then
>  SP[] = result;
> else
>  X[d] = result;

Sure enough.  I mis-read that Logical (register) and Logical (immediate) are
different in their ability to use XSP as an output.


r~