From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm5sk-0001Y3-J5 for qemu-devel@nongnu.org; Thu, 28 Nov 2013 13:00:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vm5se-00080r-Ne for qemu-devel@nongnu.org; Thu, 28 Nov 2013 13:00:06 -0500 Received: from qmta09.emeryville.ca.mail.comcast.net ([76.96.30.96]:52196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm5se-00080n-Cm for qemu-devel@nongnu.org; Thu, 28 Nov 2013 13:00:00 -0500 Message-ID: <52978416.4000606@redhat.com> Date: Thu, 28 Nov 2013 10:57:42 -0700 From: Eric Blake MIME-Version: 1.0 References: <1384914356-14231-1-git-send-email-famz@redhat.com> <5295528F.3080804@redhat.com> <20131128115654.GB4805@dhcp-200-207.str.redhat.com> <20131128144915.GF4805@dhcp-200-207.str.redhat.com> In-Reply-To: <20131128144915.GF4805@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Puwi3be2SjUwBsDCLdtiJq6fcsa3DR4ix" Subject: Re: [Qemu-devel] [PATCH v2 0/2] qemu-iotests: Filter out "qemu-io> " in all tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Fam Zheng Cc: Fam Zheng , "qemu-devel@nongnu.org" , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Puwi3be2SjUwBsDCLdtiJq6fcsa3DR4ix Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/28/2013 07:49 AM, Kevin Wolf wrote: >>>>> https://github.com/famz/qemu.git 035-filter-qemu-io >>>>> >>>>> v2: Rebase to current master. >>>>> [01] Add Reviewed-by for Eric. >>>>> [02] Update comment to describe the command for mechanical subs= titution. (Eric) >>>> >>>> Kevin, would you like to take this one? >>> >>> I would, but this way it simply doesn't work. >>> >>> The '035-filter-qemu-io' branch in your repo is something, but certai= nly >>> not this series. It may be some early RFC where you only fixed one ca= se. >>> I then found the 'iotests-filter-qemu-io' (which is already not what = you >>> said) branch and I almost would have applied it, but I noticed it's n= ot >>> exactly the same as this series; I suppose it's version 1. >>> >>> Eric reviewed _something_, but the two branches I found aren't what y= ou >>> sent, and he didn't specify the commit ID he reviewed, so I can't put= >>> his Reviewed-by tag anywhere, because I simply don't know what he loo= ked >>> at. And I've since lost track of which commit id I reviewed. >>> >>> Fam, can you push the _current_ version somewhere and tell me the >>> correct branch name and commit ID? Eric, can you then tell me if this= >>> newly pushed code matches what you reviewed? >> >> Sorry, I've pushed again to: >> >> https://github.com/famz/qemu.git for-kevin >> >> Please fetch again. >=20 > Thanks, cherry-picked the patches from that branch (commit ID of the > top is 0974950e05137c7751ec1d3c5d1b0fa5387eead9). I didn't add Eric's > Reviewed-by yet, but I'll do so when he confirms that this is what he > checked. I have now reviewed commit 0974950e05137c7751ec1d3c5d1b0fa5387eead9 in the same manner as before (manually followed the 'sed' instructions in the commit message and verified that the only differences remaining are the added filter). It appears that the only differences in this known commit id from whatever (now unknown) commit I first reviewed is thus limited to rebase differences. I'm happy with the commit, so feel free to (re-)add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Puwi3be2SjUwBsDCLdtiJq6fcsa3DR4ix Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSl4QWAAoJEKeha0olJ0NqzJ4IAJP7ThXaKpQljOm/PdBtQzbJ tXNJF22BgU6vGNaKTqHKTcuEDAPDdBvDXlIApWfBxSuvvqFnfdlUF1KdYuyg6sAV CA//IuEn1A6Tuh1kdGNrkIM5X/EaqUf+ymWQY/+4A+BudRT568RH0FqwTU1rGyGF 8Fbkm36Zttg6xasDPQAHN70OkduW+Mw2Kk1gdH/WdTugdQp15J5saY1Gzbc6zX8W Ge2N5HzQwws5cL9n5W2T034KqEcKhLlaMdSEqam2177msTrTPSjFlvNbmiPRhOHm Cluy6OjStjI+r03dFseLW9ktoLbPnwEK8D60p4+UGL5GwkA3yajQ3u72hfbT6kc= =5xYD -----END PGP SIGNATURE----- --Puwi3be2SjUwBsDCLdtiJq6fcsa3DR4ix--