From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmC4U-0007i3-UJ for qemu-devel@nongnu.org; Thu, 28 Nov 2013 19:36:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmC4P-0001fK-IV for qemu-devel@nongnu.org; Thu, 28 Nov 2013 19:36:38 -0500 Received: from mail-pd0-x22f.google.com ([2607:f8b0:400e:c02::22f]:35923) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmC4P-0001fA-9r for qemu-devel@nongnu.org; Thu, 28 Nov 2013 19:36:33 -0500 Received: by mail-pd0-f175.google.com with SMTP id w10so12697093pde.6 for ; Thu, 28 Nov 2013 16:36:32 -0800 (PST) Message-ID: <5297E185.9000000@gmail.com> Date: Fri, 29 Nov 2013 08:36:21 +0800 From: Fam Zheng MIME-Version: 1.0 References: <1384914356-14231-1-git-send-email-famz@redhat.com> <5295528F.3080804@redhat.com> <20131128115654.GB4805@dhcp-200-207.str.redhat.com> <20131128144915.GF4805@dhcp-200-207.str.redhat.com> <52978416.4000606@redhat.com> In-Reply-To: <52978416.4000606@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] qemu-iotests: Filter out "qemu-io> " in all tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Fam Zheng , "qemu-devel@nongnu.org" , Stefan Hajnoczi 于2013年11月29日 星期五 01时57分42秒,Eric Blake写到: > On 11/28/2013 07:49 AM, Kevin Wolf wrote: > >>>>>> https://github.com/famz/qemu.git 035-filter-qemu-io >>>>>> >>>>>> v2: Rebase to current master. >>>>>> [01] Add Reviewed-by for Eric. >>>>>> [02] Update comment to describe the command for mechanical substitution. (Eric) >>>>> >>>>> Kevin, would you like to take this one? >>>> >>>> I would, but this way it simply doesn't work. >>>> >>>> The '035-filter-qemu-io' branch in your repo is something, but certainly >>>> not this series. It may be some early RFC where you only fixed one case. >>>> I then found the 'iotests-filter-qemu-io' (which is already not what you >>>> said) branch and I almost would have applied it, but I noticed it's not >>>> exactly the same as this series; I suppose it's version 1. >>>> >>>> Eric reviewed _something_, but the two branches I found aren't what you >>>> sent, and he didn't specify the commit ID he reviewed, so I can't put >>>> his Reviewed-by tag anywhere, because I simply don't know what he looked >>>> at. > > And I've since lost track of which commit id I reviewed. > >>>> >>>> Fam, can you push the _current_ version somewhere and tell me the >>>> correct branch name and commit ID? Eric, can you then tell me if this >>>> newly pushed code matches what you reviewed? >>> >>> Sorry, I've pushed again to: >>> >>> https://github.com/famz/qemu.git for-kevin >>> >>> Please fetch again. >> >> Thanks, cherry-picked the patches from that branch (commit ID of the >> top is 0974950e05137c7751ec1d3c5d1b0fa5387eead9). I didn't add Eric's >> Reviewed-by yet, but I'll do so when he confirms that this is what he >> checked. > > I have now reviewed commit 0974950e05137c7751ec1d3c5d1b0fa5387eead9 in > the same manner as before (manually followed the 'sed' instructions in > the commit message and verified that the only differences remaining are > the added filter). It appears that the only differences in this known > commit id from whatever (now unknown) commit I first reviewed is thus > limited to rebase differences. I'm happy with the commit, so feel free > to (re-)add: > > Reviewed-by: Eric Blake > Thanks Eric. I'm sorry for the trouble. Fam