From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51070)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VmFGu-0001S4-MX
	for qemu-devel@nongnu.org; Thu, 28 Nov 2013 23:01:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VmFGo-0004PI-SU
	for qemu-devel@nongnu.org; Thu, 28 Nov 2013 23:01:40 -0500
Message-ID: <52981199.4020605@suse.de>
Date: Fri, 29 Nov 2013 05:01:29 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <527D70A5.7010905@FreeBSD.org> <5297B6A4.1020300@FreeBSD.org>
In-Reply-To: <5297B6A4.1020300@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] fix compilation on FreeBSD for mac_*world.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas Tobler <andreast@FreeBSD.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org

Am 28.11.2013 22:33, schrieb Andreas Tobler:
> Hello,
>=20
> On 09.11.13 00:15, Andreas Tobler wrote:
>> Hello,
>>
>> the attached patch fixes compilation on FreeBSD for
>> hw/ppc/mac_new/oldworld.c on FreeBSD.
>>
>> The affected function is present in machine/param.h on FreeBSD:
>>
>> #define round_page(x)   ((((unsigned long)(x)) + PAGE_MASK) & ~(PAGE_M=
ASK))
>>
>> To make it compile on FreeBSD I'd like to propose the below patch whic=
h
>> is in use since a longer time on the ports tree (FreeBSD) and in my
>> personal git tree.
>>
>> Thanks,
>>
>> Andreas
>>
>> Signed-off-by: Andreas Tobler <address@hidden>
>>
>=20
> This time qemu-devel list included.
>=20
> Ping?

I remember writing a patch to fix this or a very similar issue in those
files by adding a prefix for the local version. Have you checked the
list archives or git log?

Apart from that, the Sob is broken and we prefer patches git-send-email
style with a ready-to-apply commit message:
http://wiki.qemu.org/Contribute/SubmitAPatch

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg