qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, stefanha@redhat.com,
	pbonzini@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd
Date: Fri, 29 Nov 2013 16:54:56 +0800	[thread overview]
Message-ID: <52985660.9060506@linux.vnet.ibm.com> (raw)
In-Reply-To: <1385094432-1655-1-git-send-email-xiawenc@linux.vnet.ibm.com>

> v6:
>    Address Kevin's comments:
>    1: typo fix, remove device and snapshot info in error message.
>    2: use strstart().
>    3: use _require_command(), limit proto to file, since when proto=nbd
> it can't work. also changed _require_command() to tip better.
>    4: use strstart().
>    6: new patch, since I found the doc missing in debugging.
> 
  Kevin, I found there is exsiting _require_command() in common.rc, and
snapshot create can't work when PROTO=NBD for EOF write request, so
limited the work condition to file and added _require_command QEMU_NBD.
Could u take a look at it?

  parent reply	other threads:[~2013-11-29  8:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22  4:27 [Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd Wenchao Xia
2013-11-22  4:27 ` [Qemu-devel] [PATCH V6 1/6] snapshot: distinguish id and name in load_tmp Wenchao Xia
2013-11-22  4:27 ` [Qemu-devel] [PATCH V6 2/6] qemu-nbd: support internal snapshot export Wenchao Xia
2013-11-22  4:27 ` [Qemu-devel] [PATCH V6 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case Wenchao Xia
2013-12-03 13:45   ` Stefan Hajnoczi
2013-12-04  2:52     ` Wenchao Xia
2013-11-22  4:27 ` [Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for snapshot in convert Wenchao Xia
2013-12-03 11:02   ` Stefan Hajnoczi
2013-12-04  2:50     ` Wenchao Xia
2013-11-22  4:27 ` [Qemu-devel] [PATCH V6 5/6] qemu-iotests: add test for snapshot in qemu-img convert Wenchao Xia
2013-11-22  4:27 ` [Qemu-devel] [PATCH V6 6/6] qemu-nbd: add doc for option -f Wenchao Xia
2013-11-29  8:54 ` Wenchao Xia [this message]
2013-12-03  3:33   ` [Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd Wenchao Xia
2013-12-03 13:46 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52985660.9060506@linux.vnet.ibm.com \
    --to=xiawenc@linux.vnet.ibm.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).