From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmJr4-00077D-At for qemu-devel@nongnu.org; Fri, 29 Nov 2013 03:55:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmJqr-0002E0-Vg for qemu-devel@nongnu.org; Fri, 29 Nov 2013 03:55:18 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:41302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmJqr-00025u-7F for qemu-devel@nongnu.org; Fri, 29 Nov 2013 03:55:05 -0500 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 29 Nov 2013 18:55:02 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 09FCC2CE8054 for ; Fri, 29 Nov 2013 19:55:00 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rAT8aqcc2228480 for ; Fri, 29 Nov 2013 19:36:53 +1100 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rAT8swpf003638 for ; Fri, 29 Nov 2013 19:54:58 +1100 Message-ID: <52985660.9060506@linux.vnet.ibm.com> Date: Fri, 29 Nov 2013 16:54:56 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1385094432-1655-1-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1385094432-1655-1-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, Wenchao Xia > v6: > Address Kevin's comments: > 1: typo fix, remove device and snapshot info in error message. > 2: use strstart(). > 3: use _require_command(), limit proto to file, since when proto=nbd > it can't work. also changed _require_command() to tip better. > 4: use strstart(). > 6: new patch, since I found the doc missing in debugging. > Kevin, I found there is exsiting _require_command() in common.rc, and snapshot create can't work when PROTO=NBD for EOF write request, so limited the work condition to file and added _require_command QEMU_NBD. Could u take a look at it?