From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmPjW-000377-Mi for qemu-devel@nongnu.org; Fri, 29 Nov 2013 10:11:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmPjR-00048a-MQ for qemu-devel@nongnu.org; Fri, 29 Nov 2013 10:11:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmPjR-00048U-DK for qemu-devel@nongnu.org; Fri, 29 Nov 2013 10:11:49 -0500 Message-ID: <5298AEAE.2070908@redhat.com> Date: Fri, 29 Nov 2013 16:11:42 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <529895BB.5050903@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] target-i386: fix cpuid leaf 0x0d List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Liu, Jinsong" Cc: "haoxudong.hao@gmail.com" , "qemu-devel@nongnu.org" , Gleb Natapov , kvm Il 29/11/2013 15:46, Liu, Jinsong ha scritto: > Paolo Bonzini wrote: >> Il 29/11/2013 14:15, Liu, Jinsong ha scritto: >>> From e4b58c7bafc4d9f913a572a1b1cfee91c92f1637 Mon Sep 17 00:00:00 >>> 2001 >>> From: Liu Jinsong >>> Date: Fri, 22 Nov 2013 00:24:16 +0800 >>> Subject: [PATCH 1/2] target-i386: fix cpuid leaf 0x0d >>> >>> Fix cpuid leaf 0x0d which incorrectly parsed eax and ebx. >> >> There is no visible change right (the two hunks cancel each other)? >> Since you will have to post a v2, please make this explicit in the >> commit message. >> > > OK, will add explicit commit message, or, drop this patch if needed. The patch is correct, so keep it please. However, mention in the commit message that the CPUID values were valid even before this patch. Also, the QEMU side needs support for transferring the state in and out of KVM (kvm_put_xsave, kvm_get_xsave). On top of this you can add migration support using a new subsection of vmstate_cpu. Thanks! Paolo > Thanks, > Jinsong > >> >>> Signed-off-by: Liu Jinsong >>> --- >>> target-i386/cpu.c | 6 +++--- >>> 1 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >>> index 864c80e..544b57f 100644 >>> --- a/target-i386/cpu.c >>> +++ b/target-i386/cpu.c >>> @@ -335,7 +335,7 @@ typedef struct ExtSaveArea { >>> >>> static const ExtSaveArea ext_save_areas[] = { >>> [2] = { .feature = FEAT_1_ECX, .bits = CPUID_EXT_AVX, >>> - .offset = 0x100, .size = 0x240 }, >>> + .offset = 0x240, .size = 0x100 }, >>> }; >>> >>> const char *get_register_name_32(unsigned int reg) >>> @@ -2225,8 +2225,8 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t >>> index, uint32_t count, const ExtSaveArea *esa = >>> &ext_save_areas[count]; if >>> ((env->features[esa->feature] & esa->bits) == >>> esa->bits && (kvm_mask & (1 << count)) != 0) { >>> - *eax = esa->offset; >>> - *ebx = esa->size; >>> + *eax = esa->size; >>> + *ebx = esa->offset; >>> } >>> } >>> break; >>> -- >>> 1.7.1 >