From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35224)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VmPwf-0007Ez-3a
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 10:25:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VmPwZ-0000xk-4v
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 10:25:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VmPwY-0000xK-T5
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 10:25:23 -0500
Message-ID: <5298B1DD.60307@redhat.com>
Date: Fri, 29 Nov 2013 16:25:17 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1385737124-13964-1-git-send-email-marcandre.lureau@gmail.com>
	<1385737124-13964-13-git-send-email-marcandre.lureau@gmail.com>
In-Reply-To: <1385737124-13964-13-git-send-email-marcandre.lureau@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 12/13] nbd: finish any pending coroutine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com

Il 29/11/2013 15:58, Marc-Andr=C3=A9 Lureau ha scritto:
>      closesocket(client->sock);
> +    /* finish any pending coroutines */
> +    client->reply.handle =3D 0;
> +    client->reply.error =3D EIO;
> +    nbd_recv_coroutines_enter_all(client);

What about using the same shutdown(2) trick as the server?  Then you can
call nbd_recv_coroutines_enter_all() while client->sock is still valid,
which I find more robust.

Paolo