From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36203)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VmPzT-00031j-Vi
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 10:28:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VmPzO-0001jb-1h
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 10:28:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:13295)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VmPzN-0001jU-Qx
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 10:28:17 -0500
Message-ID: <5298B28C.50307@redhat.com>
Date: Fri, 29 Nov 2013 16:28:12 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1385737124-13964-1-git-send-email-marcandre.lureau@gmail.com>
	<1385737124-13964-12-git-send-email-marcandre.lureau@gmail.com>
In-Reply-To: <1385737124-13964-12-git-send-email-marcandre.lureau@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 11/13] nbd: make session_close() idempotent
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Cc: =?UTF-8?B?TWFyYy1BbmRyw6kgTA==?= =?UTF-8?B?dXJlYXU=?= <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, kraxel@redhat.com

Il 29/11/2013 15:58, Marc-Andr=C3=A9 Lureau ha scritto:
> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>=20
> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> ---
>  block/nbd-client.c | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/block/nbd-client.c b/block/nbd-client.c
> index e29227b..c0ad2c2 100644
> --- a/block/nbd-client.c
> +++ b/block/nbd-client.c
> @@ -337,7 +337,12 @@ static void nbd_teardown_connection(NbdClientSessi=
on *client)
> =20
>  void nbd_client_session_close(NbdClientSession *client)
>  {
> +    if (!client->bs) {
> +        return;
> +    }
> +
>      nbd_teardown_connection(client);
> +    client->bs =3D NULL;
>  }
> =20
>  int nbd_client_session_init(NbdClientSession *client, BlockDriverState=
 *bs,
>=20

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Perhaps "make nbd_client_session_close() idempotent" in the commit messag=
e.

Paolo