qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 23/30] virtio-blk: Convert to QOM realize
Date: Fri, 29 Nov 2013 17:08:36 +0100	[thread overview]
Message-ID: <5298BC04.7040500@suse.de> (raw)
In-Reply-To: <1385720262-14107-24-git-send-email-pbonzini@redhat.com>

Am 29.11.2013 11:17, schrieb Paolo Bonzini:
> diff --git a/tests/qdev-monitor-test.c b/tests/qdev-monitor-test.c
> index 33a8ea4..ba7f9cc 100644
> --- a/tests/qdev-monitor-test.c
> +++ b/tests/qdev-monitor-test.c
> @@ -32,10 +32,8 @@ static void test_device_add(void)
>                     "}}");
>      g_assert(response);
>      error = qdict_get_qdict(response, "error");
> -    g_assert(!strcmp(qdict_get_try_str(error, "class") ?: "",
> -                     "GenericError"));
>      g_assert(!strcmp(qdict_get_try_str(error, "desc") ?: "",
> -                     "Device initialization failed."));
> +                     "Device needs media, but drive is empty"));
>      QDECREF(response);
>  
>      /* Delete the drive */

Thanks for finding and fixing this qtest failure!

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-11-29 16:08 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 10:17 [Qemu-devel] [PATCH v4 00/30] virtio: cleanup, fix hot-unplug, move to realize Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 01/30] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 02/30] virtio-bus: remove vdev field Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 03/30] virtio-ccw: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 04/30] virtio-pci: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 05/30] virtio-bus: cleanup plug/unplug interface Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 06/30] virtio-blk: switch exit callback to VirtioDeviceClass Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 07/30] virtio-serial: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 08/30] virtio-net: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 09/30] virtio-scsi: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 10/30] virtio-balloon: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 11/30] virtio-rng: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 12/30] virtio-pci: add device_unplugged callback Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 13/30] virtio-blk-dataplane: Improve error reporting Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 14/30] virtio-9p: QOM realize preparations Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 15/30] virtio-blk: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 16/30] virtio-serial: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 17/30] virtio-net: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 18/30] virtio-balloon: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 19/30] virtio-rng: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 20/30] virtio-scsi: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 21/30] virtio: Start converting VirtioDevice to QOM realize Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 22/30] virtio-9p: Convert " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 23/30] virtio-blk: " Paolo Bonzini
2013-11-29 16:08   ` Andreas Färber [this message]
2013-11-29 10:17 ` [Qemu-devel] [PATCH 24/30] virtio-serial: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 25/30] virtio-net: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 26/30] virtio-balloon: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 27/30] virtio-rng: " Paolo Bonzini
2013-11-29 16:10   ` Andreas Färber
2013-11-29 16:12     ` Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 28/30] virtio-scsi: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 29/30] virtio: Complete converting VirtioDevice " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 30/30] virtio: Convert exit to unrealize Paolo Bonzini
2013-12-07  1:46 ` [Qemu-devel] [PATCH v4 00/30] virtio: cleanup, fix hot-unplug, move to realize Andreas Färber
2013-12-09 17:57 ` Paolo Bonzini
2013-12-09 18:52   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5298BC04.7040500@suse.de \
    --to=afaerber@suse.de \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).