From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VmQca-00046J-Mn
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 11:08:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VmQcT-0007UE-CV
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 11:08:48 -0500
Received: from cantor2.suse.de ([195.135.220.15]:54013 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VmQcT-0007UA-5c
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 11:08:41 -0500
Message-ID: <5298BC04.7040500@suse.de>
Date: Fri, 29 Nov 2013 17:08:36 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1385720262-14107-1-git-send-email-pbonzini@redhat.com>
	<1385720262-14107-24-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1385720262-14107-24-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 23/30] virtio-blk: Convert to QOM realize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, mst@redhat.com

Am 29.11.2013 11:17, schrieb Paolo Bonzini:
> diff --git a/tests/qdev-monitor-test.c b/tests/qdev-monitor-test.c
> index 33a8ea4..ba7f9cc 100644
> --- a/tests/qdev-monitor-test.c
> +++ b/tests/qdev-monitor-test.c
> @@ -32,10 +32,8 @@ static void test_device_add(void)
>                     "}}");
>      g_assert(response);
>      error =3D qdict_get_qdict(response, "error");
> -    g_assert(!strcmp(qdict_get_try_str(error, "class") ?: "",
> -                     "GenericError"));
>      g_assert(!strcmp(qdict_get_try_str(error, "desc") ?: "",
> -                     "Device initialization failed."));
> +                     "Device needs media, but drive is empty"));
>      QDECREF(response);
> =20
>      /* Delete the drive */

Thanks for finding and fixing this qtest failure!

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg