From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 27/30] virtio-rng: Convert to QOM realize
Date: Fri, 29 Nov 2013 17:12:17 +0100 [thread overview]
Message-ID: <5298BCE1.8070105@redhat.com> (raw)
In-Reply-To: <5298BC91.9030000@suse.de>
Il 29/11/2013 17:10, Andreas Färber ha scritto:
>> > +#define VIRTIO_RNG_GET_PARENT_CLASS(obj) \
>> > + OBJECT_GET_PARENT_CLASS(obj, TYPE_VIRTIO_RNG)
>> >
>> > /* The Virtio ID for the virtio rng device */
>> > #define VIRTIO_ID_RNG 4
> This hunk seems a leftover from v2. How to proceed?
Possibility 1: mst removes it
Possibility 2: I remove it and resend
Possibility 3: mst gives Acked-by, I remove it and send pull request
Paolo
next prev parent reply other threads:[~2013-11-29 16:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 10:17 [Qemu-devel] [PATCH v4 00/30] virtio: cleanup, fix hot-unplug, move to realize Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 01/30] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 02/30] virtio-bus: remove vdev field Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 03/30] virtio-ccw: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 04/30] virtio-pci: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 05/30] virtio-bus: cleanup plug/unplug interface Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 06/30] virtio-blk: switch exit callback to VirtioDeviceClass Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 07/30] virtio-serial: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 08/30] virtio-net: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 09/30] virtio-scsi: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 10/30] virtio-balloon: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 11/30] virtio-rng: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 12/30] virtio-pci: add device_unplugged callback Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 13/30] virtio-blk-dataplane: Improve error reporting Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 14/30] virtio-9p: QOM realize preparations Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 15/30] virtio-blk: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 16/30] virtio-serial: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 17/30] virtio-net: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 18/30] virtio-balloon: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 19/30] virtio-rng: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 20/30] virtio-scsi: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 21/30] virtio: Start converting VirtioDevice to QOM realize Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 22/30] virtio-9p: Convert " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 23/30] virtio-blk: " Paolo Bonzini
2013-11-29 16:08 ` Andreas Färber
2013-11-29 10:17 ` [Qemu-devel] [PATCH 24/30] virtio-serial: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 25/30] virtio-net: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 26/30] virtio-balloon: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 27/30] virtio-rng: " Paolo Bonzini
2013-11-29 16:10 ` Andreas Färber
2013-11-29 16:12 ` Paolo Bonzini [this message]
2013-11-29 10:17 ` [Qemu-devel] [PATCH 28/30] virtio-scsi: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 29/30] virtio: Complete converting VirtioDevice " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 30/30] virtio: Convert exit to unrealize Paolo Bonzini
2013-12-07 1:46 ` [Qemu-devel] [PATCH v4 00/30] virtio: cleanup, fix hot-unplug, move to realize Andreas Färber
2013-12-09 17:57 ` Paolo Bonzini
2013-12-09 18:52 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5298BCE1.8070105@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).