From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46696)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VmQg7-0006u8-Oq
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 11:12:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VmQg1-0008Tp-QQ
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 11:12:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14019)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VmQg1-0008Tg-Ie
	for qemu-devel@nongnu.org; Fri, 29 Nov 2013 11:12:21 -0500
Message-ID: <5298BCE1.8070105@redhat.com>
Date: Fri, 29 Nov 2013 17:12:17 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1385720262-14107-1-git-send-email-pbonzini@redhat.com>
	<1385720262-14107-28-git-send-email-pbonzini@redhat.com>
	<5298BC91.9030000@suse.de>
In-Reply-To: <5298BC91.9030000@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 27/30] virtio-rng: Convert to QOM realize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, mst@redhat.com

Il 29/11/2013 17:10, Andreas F=C3=A4rber ha scritto:
>> > +#define VIRTIO_RNG_GET_PARENT_CLASS(obj) \
>> > +        OBJECT_GET_PARENT_CLASS(obj, TYPE_VIRTIO_RNG)
>> > =20
>> >  /* The Virtio ID for the virtio rng device */
>> >  #define VIRTIO_ID_RNG    4
> This hunk seems a leftover from v2. How to proceed?

Possibility 1: mst removes it

Possibility 2: I remove it and resend

Possibility 3: mst gives Acked-by, I remove it and send pull request

Paolo