From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 4/4] i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash
Date: Fri, 29 Nov 2013 17:29:51 +0100 [thread overview]
Message-ID: <5298C0FF.6010404@redhat.com> (raw)
In-Reply-To: <5298B304.1050504@redhat.com>
Il 29/11/2013 16:30, Laszlo Ersek ha scritto:
>> > Zero-fill immediately followed by read. Suggest to drop memset().
> Same as above. memread() is unable to report errors. Some C library
> functions also require you to set errno to zero first, then call the
> function, then check errno, because some of the return values are
> overlapped by success and failure returns. For memread() there's no
> distinction in return value at all.
>
Errors in memread() will cause an assertion failure, but I think it's
okay to use g_malloc0.
That said, I agree that the common coding conventions (as well as the
English grammar) makes "char unsigned" look a bit weird.
Regarding usage of fixtures, I think it's within your artistic license
(quoting) and it's good to have an example to cut-and-paste from
Paolo.
next prev parent reply other threads:[~2013-11-29 16:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 18:09 [Qemu-devel] [PATCH v2 0/4] i440fx-test: check firmware visibility Laszlo Ersek
2013-11-28 18:09 ` [Qemu-devel] [PATCH v2 1/4] i440fx-test: qtest_start() should be paired with qtest_end() Laszlo Ersek
2013-11-29 13:23 ` Markus Armbruster
2013-11-28 18:09 ` [Qemu-devel] [PATCH v2 2/4] i440fx-test: give each GTest case its own qtest Laszlo Ersek
2013-11-29 14:53 ` Eduardo Habkost
2013-11-29 15:35 ` Laszlo Ersek
2013-11-28 18:09 ` [Qemu-devel] [PATCH v2 3/4] i440fx-test: generate temporary firmware blob Laszlo Ersek
2013-11-29 13:57 ` Markus Armbruster
2013-11-29 15:07 ` Laszlo Ersek
2013-11-29 16:26 ` Paolo Bonzini
2013-12-02 9:28 ` Markus Armbruster
2013-11-28 18:09 ` [Qemu-devel] [PATCH v2 4/4] i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash Laszlo Ersek
2013-11-29 14:09 ` Markus Armbruster
2013-11-29 15:30 ` Laszlo Ersek
2013-11-29 16:29 ` Paolo Bonzini [this message]
2013-11-28 18:18 ` [Qemu-devel] [PATCH v2 0/4] i440fx-test: check firmware visibility Laszlo Ersek
2013-11-29 17:12 ` Andreas Färber
2013-11-29 17:18 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5298C0FF.6010404@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).