Re: [Qemu-devel] [PATCH v2 0/4] i440fx-test: check firmware visibility

[Laszlo Ersek <lersek@redhat.com>]

On 11/29/13 18:12, Andreas Färber wrote:
> Am 28.11.2013 19:18, schrieb Laszlo Ersek:
>> On 11/28/13 19:09, Laszlo Ersek wrote:
>>
>>> Changes in v2:
>>> - Rebased ("-display none" is the default now).
>>>
>>> - I looked into memory management prudence in qtest, and I can see that
>>>   we don't care about leaking small objects at all. (See for example
>>>   qpci_device_foreach(), which calls qpci_device_find() in a loop, and
>>>   leaks the retval every time.)
>>
>> Sorry, last sentence missing:
>> "Which is why I didn't try to plug such leaks in my series."
> 
> Laszlo,
> 
>> NB: If I don't get feedback for this, I'm dropping it.
>> http://thread.gmane.org/gmane.comp.emulators.qemu/240173/focus=241207
> 
> If you're specifically waiting on my review, being the only one CC'ed,
> you'll need to be more patient as other series have been waiting longer
> on me.
> 
> Sorry,
> Andreas

I included the reference to show that I'm doing this in response to your
request. It's not something I'd have invested time in on my own behalf.
(Especially not three rounds.)

Review-wise, I'm fine with any review that gets the series merged and
the burden off my shoulder. There are patches where I feel I need advice
or sanity checking, this series is not one of them.

> P.S. Hope you're feeling better since KVM Forum. :)

My health is better, thank you very much for asking!

Cheers,
Laszlo