From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnPcH-0004Yb-17 for qemu-devel@nongnu.org; Mon, 02 Dec 2013 04:16:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnPc9-0001Xc-OJ for qemu-devel@nongnu.org; Mon, 02 Dec 2013 04:16:32 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:35672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnPc8-0001XU-VX for qemu-devel@nongnu.org; Mon, 02 Dec 2013 04:16:25 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Dec 2013 19:16:21 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id A73D93578053 for ; Mon, 2 Dec 2013 20:16:19 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rB28w8qk61079770 for ; Mon, 2 Dec 2013 19:58:09 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rB29GI04024462 for ; Mon, 2 Dec 2013 20:16:18 +1100 Message-ID: <529C4FDF.6080509@linux.vnet.ibm.com> Date: Mon, 02 Dec 2013 17:16:15 +0800 From: Lei Li MIME-Version: 1.0 References: <1385719584-21114-1-git-send-email-lilei@linux.vnet.ibm.com> <52986BB9.1060206@redhat.com> In-Reply-To: <52986BB9.1060206@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/17 v4] Localhost migration with side channel for ram List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aarcange@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, aliguori@amazon.com, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com On 11/29/2013 06:26 PM, Paolo Bonzini wrote: > Il 29/11/2013 11:06, Lei Li ha scritto: >> This patch series tries to introduce a mechanism using side >> channel pipe for RAM via SCM_RIGHTS with unix domain socket >> protocol migration. >> >> This side channel is used for the page flipping by vmsplice, >> which is the internal mechanism for localhost migration that >> we are trying to add to QEMU. The backgroud info and previous >> patch series for reference, >> >> Localhost migration >> http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg02916.html >> >> migration: Introduce side channel for RAM >> http://lists.gnu.org/archive/html/qemu-devel/2013-09/msg04043.html >> >> I have picked patches from the localhost migration series and rebased >> it on the series of side channel, now it is a complete series that >> passed the basic test. > One change: please rename the capability to x-unix-page-flipping for > now. No need to rename the function migrate_unix_page_flipping(), only > the capability name in qapi-schema.json (and references to the enum > MIGRATION_CAPABILITY_UNIX_PAGE_FLIPPING). > > With that change, v5 will get "Reviewed-by: Paolo Bonzini > ". Hi Paolo, Will update soon, thanks! > > Thanks! > > Paolo > >> Please let me know if there is anything needs to be fixed or improved. >> Your suggestions and comments are very welcome, and thanks to Paolo >> for his continued review and useful suggestions. >> >> Changes since V3: >> Address comments from Paolo including: >> >> - Get rid of useless check in send_pipefd() and the override >> of before_ram_iterate, send pipefd in the first save_page >> call, qemu_get_byte() in the first ram_load correspondingly. >> - Add new argument ram_addr_t to hook_ram_load to cut half of >> the data transferred on the socket. >> - Add transition from 'debug' to 'memory-stale'. >> - Other minor fixes. >> >> Changes since V2: >> Address comments from Paolo including: >> >> - Doc improvement for QAPI. >> - Use callback get_buffer as the only one receiver. >> - Rename the new RunState flipping-migrate to memory-stale, and >> add transition from 'prelaunch' to 'memory-stale'. >> - Other minor fixes. >> >> Changes since V1: >> Address suggestions from Paolo Bonzini including: >> >> - Use Unix socket QEMUFile as basis of code and adjust the way >> of overriding RDMA hooks. >> - Involve the vmsplice for page flipping. >> - Add new RunState RUN_STATE_FLIPPING_MIGRATE and add it to >> runstate_needs_reset() for the adjustment of the current >> migration process with page flipping. >> >> >> >> Lei Li (17): >> QAPI: introduce magration capability unix_page_flipping >> migration: add migrate_unix_page_flipping() >> qmp-command.hx: add missing docs for migration capabilites >> migration-local: add QEMUFileLocal with socket based QEMUFile >> migration-local: introduce qemu_fopen_socket_local() >> migration-local: add send_pipefd() >> save_page: replace block_offset with a MemoryRegion >> migration-local: override save_page for page transmit >> savevm: adjust ram_control_save_page with page flipping >> add unix_msgfd_lookup() to callback get_buffer >> add argument ram_addr_t to hook_ram_load >> migration-local: override hook_ram_load >> migration-unix: replace qemu_fopen_socket with qemu_fopen_socket_local >> add new RanState RAN_STATE_MEMORY_STALE >> migration-unix: page flipping support on unix outgoing >> migration: adjust migration_thread() process for unix_page_flipping >> hmp: better fomat for info migrate_capabilities >> >> Makefile.target | 1 + >> arch_init.c | 4 +- >> migration-local.c | 512 ++++++++++++++++++++++++++++++++++++++++++ >> hmp.c | 5 +- >> include/migration/migration.h | 3 + >> include/migration/qemu-file.h | 2 + >> migration-unix.c | 27 ++- >> migration-rdma.c | 4 +- >> migration.c | 18 +- >> qapi-schema.json | 18 +- >> qmp-commands.hx | 8 + >> savevm.c | 21 +- >> vl.c | 12 +- >> 13 files changed, 617 insertions(+), 27 deletions(-) >> create mode 100644 migration-local.c >> > -- Lei