From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, jan.kiszka@siemens.com,
qemu-devel@nongnu.org, anthony@codemonkey.ws, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] memory.c: bugfix - ref counting mismatch in memory_region_find
Date: Mon, 02 Dec 2013 15:22:58 +0100 [thread overview]
Message-ID: <529C97C2.9010600@redhat.com> (raw)
In-Reply-To: <1385994059-16812-1-git-send-email-marcel.a@redhat.com>
Il 02/12/2013 15:20, Marcel Apfelbaum ha scritto:
> 'address_space_get_flatview' gets a reference to a FlatView.
> If the flatview lookup fails, the code returns without
> "unreferencing" the view.
>
> Cc: qemu-stable@nongnu.org
>
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
> memory.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/memory.c b/memory.c
> index 28f6449..7764314 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1596,6 +1596,7 @@ MemoryRegionSection memory_region_find(MemoryRegion *mr,
> view = address_space_get_flatview(as);
> fr = flatview_lookup(view, range);
> if (!fr) {
> + flatview_unref(view);
> return ret;
> }
>
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
prev parent reply other threads:[~2013-12-02 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 14:20 [Qemu-devel] [PATCH] memory.c: bugfix - ref counting mismatch in memory_region_find Marcel Apfelbaum
2013-12-02 14:22 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C97C2.9010600@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).