From: Alon Levy <alevy@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default
Date: Mon, 02 Dec 2013 17:03:27 +0200 [thread overview]
Message-ID: <529CA13F.3010401@redhat.com> (raw)
In-Reply-To: <1385980046-30995-1-git-send-email-kraxel@redhat.com>
On 12/02/2013 12:27 PM, Gerd Hoffmann wrote:
> Video streaming detection heuristics in spice-server have problems
> keeping modern desktop animations (as done by gnome shell) and real
> video playback apart. This leads to jpeg compression artefacts on
> your desktop, due to spice using mjpeg to send what it thinks is
> a video stream.
>
> Turn off video detection by default to avoid these artifacts.
>
Reviewed-by: Alon Levy <alevy@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ui/spice-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index e4d533d..9fb9544 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -776,6 +776,8 @@ void qemu_spice_init(void)
> if (str) {
> int streaming_video = parse_stream_video(str);
> spice_server_set_streaming_video(spice_server, streaming_video);
> + } else {
> + spice_server_set_streaming_video(spice_server, SPICE_STREAM_VIDEO_OFF);
> }
>
> spice_server_set_agent_mouse
>
prev parent reply other threads:[~2013-12-02 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 10:27 [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default Gerd Hoffmann
2013-12-02 15:03 ` Alon Levy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529CA13F.3010401@redhat.com \
--to=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).