* [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default
@ 2013-12-02 10:27 Gerd Hoffmann
2013-12-02 15:03 ` Alon Levy
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2013-12-02 10:27 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Anthony Liguori
Video streaming detection heuristics in spice-server have problems
keeping modern desktop animations (as done by gnome shell) and real
video playback apart. This leads to jpeg compression artefacts on
your desktop, due to spice using mjpeg to send what it thinks is
a video stream.
Turn off video detection by default to avoid these artifacts.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/spice-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index e4d533d..9fb9544 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -776,6 +776,8 @@ void qemu_spice_init(void)
if (str) {
int streaming_video = parse_stream_video(str);
spice_server_set_streaming_video(spice_server, streaming_video);
+ } else {
+ spice_server_set_streaming_video(spice_server, SPICE_STREAM_VIDEO_OFF);
}
spice_server_set_agent_mouse
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default
2013-12-02 10:27 [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default Gerd Hoffmann
@ 2013-12-02 15:03 ` Alon Levy
0 siblings, 0 replies; 2+ messages in thread
From: Alon Levy @ 2013-12-02 15:03 UTC (permalink / raw)
To: qemu-devel
On 12/02/2013 12:27 PM, Gerd Hoffmann wrote:
> Video streaming detection heuristics in spice-server have problems
> keeping modern desktop animations (as done by gnome shell) and real
> video playback apart. This leads to jpeg compression artefacts on
> your desktop, due to spice using mjpeg to send what it thinks is
> a video stream.
>
> Turn off video detection by default to avoid these artifacts.
>
Reviewed-by: Alon Levy <alevy@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ui/spice-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index e4d533d..9fb9544 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -776,6 +776,8 @@ void qemu_spice_init(void)
> if (str) {
> int streaming_video = parse_stream_video(str);
> spice_server_set_streaming_video(spice_server, streaming_video);
> + } else {
> + spice_server_set_streaming_video(spice_server, SPICE_STREAM_VIDEO_OFF);
> }
>
> spice_server_set_agent_mouse
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-02 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-02 10:27 [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default Gerd Hoffmann
2013-12-02 15:03 ` Alon Levy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).