From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnV2C-0007ha-Pg for qemu-devel@nongnu.org; Mon, 02 Dec 2013 10:03:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnV26-000589-R2 for qemu-devel@nongnu.org; Mon, 02 Dec 2013 10:03:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnV26-00057x-J3 for qemu-devel@nongnu.org; Mon, 02 Dec 2013 10:03:34 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB2F3Vfi005998 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 2 Dec 2013 10:03:32 -0500 Received: from blues.lan (vpn1-4-122.ams2.redhat.com [10.36.4.122]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rB2F3SCh025120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 2 Dec 2013 10:03:30 -0500 Message-ID: <529CA13F.3010401@redhat.com> Date: Mon, 02 Dec 2013 17:03:27 +0200 From: Alon Levy MIME-Version: 1.0 References: <1385980046-30995-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1385980046-30995-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 12/02/2013 12:27 PM, Gerd Hoffmann wrote: > Video streaming detection heuristics in spice-server have problems > keeping modern desktop animations (as done by gnome shell) and real > video playback apart. This leads to jpeg compression artefacts on > your desktop, due to spice using mjpeg to send what it thinks is > a video stream. > > Turn off video detection by default to avoid these artifacts. > Reviewed-by: Alon Levy > Signed-off-by: Gerd Hoffmann > --- > ui/spice-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index e4d533d..9fb9544 100644 > --- a/ui/spice-core.c > +++ b/ui/spice-core.c > @@ -776,6 +776,8 @@ void qemu_spice_init(void) > if (str) { > int streaming_video = parse_stream_video(str); > spice_server_set_streaming_video(spice_server, streaming_video); > + } else { > + spice_server_set_streaming_video(spice_server, SPICE_STREAM_VIDEO_OFF); > } > > spice_server_set_agent_mouse >