qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Baboval <baboval@spineless.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 12/15] input: mouse: add qemu_input_is_absolute()
Date: Mon, 02 Dec 2013 14:05:02 -0500	[thread overview]
Message-ID: <529CD9DE.6030702@spineless.org> (raw)
In-Reply-To: <1385649010-7034-13-git-send-email-kraxel@redhat.com>

Perhaps this should just return the mask instead of a boolean? It would 
be nice at some point to handle a USB HID style device that can send 
both relative and absolute events, for example.

Though perhaps that would be better as future work, since this is a nice 
drop-in replacement for the old call.

On 11/28/2013 09:30 AM, Gerd Hoffmann wrote:
> Same as kbd_mouse_is_absolute(), but using new input core.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   include/ui/input.h | 1 +
>   ui/input.c         | 8 ++++++++
>   2 files changed, 9 insertions(+)
>
> diff --git a/include/ui/input.h b/include/ui/input.h
> index 0d79342..43b9afc 100644
> --- a/include/ui/input.h
> +++ b/include/ui/input.h
> @@ -39,6 +39,7 @@ void qemu_input_queue_btn(QemuConsole *src, InputButton btn, bool down);
>   void qemu_input_update_buttons(QemuConsole *src, uint32_t *button_map,
>                                  uint32_t button_old, uint32_t button_new);
>   
> +bool qemu_input_is_absolute(void);
>   int qemu_input_scale_axis(int value, int size_in, int size_out);
>   InputEvent *qemu_input_event_new_move(InputEventKind kind,
>                                         InputAxis axis, int value);
> diff --git a/ui/input.c b/ui/input.c
> index abfe3a3..719c427 100644
> --- a/ui/input.c
> +++ b/ui/input.c
> @@ -167,6 +167,14 @@ void qemu_input_update_buttons(QemuConsole *src, uint32_t *button_map,
>       }
>   }
>   
> +bool qemu_input_is_absolute(void)
> +{
> +    QemuInputHandlerState *s;
> +
> +    s = qemu_input_find_handler(INPUT_EVENT_MASK_REL | INPUT_EVENT_MASK_ABS);
> +    return (s != NULL) && (s->handler->mask & INPUT_EVENT_MASK_ABS);
> +}
> +
>   int qemu_input_scale_axis(int value, int size_in, int size_out)
>   {
>       if (size_in < 2) {

  reply	other threads:[~2013-12-02 19:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 14:29 [Qemu-devel] [RFC PATCH 00/15] input: rewrite qemu input layer Gerd Hoffmann
2013-11-28 14:29 ` [Qemu-devel] [RFC PATCH 01/15] console: export QemuConsole index, width, height Gerd Hoffmann
2013-11-28 14:29 ` [Qemu-devel] [RFC PATCH 02/15] input: rename file to legacy Gerd Hoffmann
2013-11-28 14:29 ` [Qemu-devel] [RFC PATCH 03/15] input: define event types using qapi Gerd Hoffmann
2013-12-02 19:12   ` Eric Blake
2013-12-03  8:11     ` Gerd Hoffmann
2013-11-28 14:29 ` [Qemu-devel] [RFC PATCH 04/15] input: add core bits of the new input layer Gerd Hoffmann
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 05/15] input: keyboard: add helper functions to core Gerd Hoffmann
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 06/15] input: keyboard: switch legacy handlers to new core Gerd Hoffmann
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 07/15] input: keyboard: switch qmp_send_key() " Gerd Hoffmann
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 08/15] input: keyboard: switch gtk ui " Gerd Hoffmann
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 09/15] input: keyboard: switch sdl ui to new core [wip] Gerd Hoffmann
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 10/15] input: mouse: add helpers functions to core Gerd Hoffmann
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 11/15] input: mouse: add graphic_rotate support Gerd Hoffmann
2013-12-02 19:00   ` John Baboval
2013-12-03  8:58     ` Gerd Hoffmann
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 12/15] input: mouse: add qemu_input_is_absolute() Gerd Hoffmann
2013-12-02 19:05   ` John Baboval [this message]
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 13/15] input: mouse: switch legacy handlers to new core Gerd Hoffmann
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 14/15] input: mouse: switch gtk ui " Gerd Hoffmann
2013-11-28 14:30 ` [Qemu-devel] [RFC PATCH 15/15] input: mouse: switch sdl " Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529CD9DE.6030702@spineless.org \
    --to=baboval@spineless.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).