From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnYoI-0006NI-Ur for qemu-devel@nongnu.org; Mon, 02 Dec 2013 14:05:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnYoB-0006tb-D6 for qemu-devel@nongnu.org; Mon, 02 Dec 2013 14:05:34 -0500 Received: from maverick.spineless.org ([71.174.98.242]:48577 helo=spineless.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnYoB-0006tL-8L for qemu-devel@nongnu.org; Mon, 02 Dec 2013 14:05:27 -0500 Received: from [216.57.91.130] (helo=[10.204.240.225]) by spineless.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1VnYoA-0002AQ-2E for qemu-devel@nongnu.org; Mon, 02 Dec 2013 14:05:26 -0500 Message-ID: <529CD9DE.6030702@spineless.org> Date: Mon, 02 Dec 2013 14:05:02 -0500 From: John Baboval MIME-Version: 1.0 References: <1385649010-7034-1-git-send-email-kraxel@redhat.com> <1385649010-7034-13-git-send-email-kraxel@redhat.com> In-Reply-To: <1385649010-7034-13-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 12/15] input: mouse: add qemu_input_is_absolute() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Perhaps this should just return the mask instead of a boolean? It would be nice at some point to handle a USB HID style device that can send both relative and absolute events, for example. Though perhaps that would be better as future work, since this is a nice drop-in replacement for the old call. On 11/28/2013 09:30 AM, Gerd Hoffmann wrote: > Same as kbd_mouse_is_absolute(), but using new input core. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/input.h | 1 + > ui/input.c | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/include/ui/input.h b/include/ui/input.h > index 0d79342..43b9afc 100644 > --- a/include/ui/input.h > +++ b/include/ui/input.h > @@ -39,6 +39,7 @@ void qemu_input_queue_btn(QemuConsole *src, InputButton btn, bool down); > void qemu_input_update_buttons(QemuConsole *src, uint32_t *button_map, > uint32_t button_old, uint32_t button_new); > > +bool qemu_input_is_absolute(void); > int qemu_input_scale_axis(int value, int size_in, int size_out); > InputEvent *qemu_input_event_new_move(InputEventKind kind, > InputAxis axis, int value); > diff --git a/ui/input.c b/ui/input.c > index abfe3a3..719c427 100644 > --- a/ui/input.c > +++ b/ui/input.c > @@ -167,6 +167,14 @@ void qemu_input_update_buttons(QemuConsole *src, uint32_t *button_map, > } > } > > +bool qemu_input_is_absolute(void) > +{ > + QemuInputHandlerState *s; > + > + s = qemu_input_find_handler(INPUT_EVENT_MASK_REL | INPUT_EVENT_MASK_ABS); > + return (s != NULL) && (s->handler->mask & INPUT_EVENT_MASK_ABS); > +} > + > int qemu_input_scale_axis(int value, int size_in, int size_out) > { > if (size_in < 2) {