From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vngjn-0004ej-BA for qemu-devel@nongnu.org; Mon, 02 Dec 2013 22:33:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vngje-0005bn-E3 for qemu-devel@nongnu.org; Mon, 02 Dec 2013 22:33:27 -0500 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:57704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vngjd-0005WV-P3 for qemu-devel@nongnu.org; Mon, 02 Dec 2013 22:33:18 -0500 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Dec 2013 09:03:10 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id EC412E004A for ; Tue, 3 Dec 2013 09:05:17 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rB33X4U34653508 for ; Tue, 3 Dec 2013 09:03:04 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rB33X6Ej026187 for ; Tue, 3 Dec 2013 09:03:06 +0530 Message-ID: <529D50F2.5030203@linux.vnet.ibm.com> Date: Tue, 03 Dec 2013 11:33:06 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1385094432-1655-1-git-send-email-xiawenc@linux.vnet.ibm.com> <52985660.9060506@linux.vnet.ibm.com> In-Reply-To: <52985660.9060506@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, Wenchao Xia ÓÚ 2013/11/29 16:54, Wenchao Xia дµÀ: >> v6: >> Address Kevin's comments: >> 1: typo fix, remove device and snapshot info in error message. >> 2: use strstart(). >> 3: use _require_command(), limit proto to file, since when proto=nbd >> it can't work. also changed _require_command() to tip better. >> 4: use strstart(). >> 6: new patch, since I found the doc missing in debugging. >> > Kevin, I found there is exsiting _require_command() in common.rc, and > snapshot create can't work when PROTO=NBD for EOF write request, so > limited the work condition to file and added _require_command QEMU_NBD. > Could u take a look at it? > > Hello, is this version OK to be merged?