From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Wenchao Xia <xiawenc@linux.vnet.ibm.com>,
stefanha@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes
Date: Tue, 03 Dec 2013 18:33:01 +0800 [thread overview]
Message-ID: <529DB35D.5070408@redhat.com> (raw)
In-Reply-To: <20131203092801.GC9956@dhcp-200-207.str.redhat.com>
On 2013年12月03日 17:28, Kevin Wolf wrote:
> Am 03.12.2013 um 09:21 hat Fam Zheng geschrieben:
>> On 2013年12月03日 14:05, Wenchao Xia wrote:
>>
>>>
>>> Why forbid mode = writeback?
>>>
>>
>> These test cases used to run with only possibly "writethrough", or "none".
>> And they don't work with writeback, at least in my case. So I didn't add
>> other modes here.
>
> I suspect that the tests allowing writethrough might also work with
> directsync. Did you give that one a try?
>
I guess so. Except for my /tmp is tmpfs and complains about O_DIRECT. It
works for me with "TMPDIR=/var/tmp".
> 026 has different output for wt and wb modes, this is why writeback
> fails. It should probably check against 026.out.nocache (which would
> have to be renamed as 026.out.wb) instead of 026.out. That's something
> for a separate series, though.
>
Yes, good idea. I'll do this and the directsync including in the next
series.
Fam
next prev parent reply other threads:[~2013-12-03 10:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 1:43 [Qemu-devel] [PATCH v4 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback" Fam Zheng
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 1/6] qemu-iotests: Add "-c <cache-mode>" option Fam Zheng
2013-12-03 6:31 ` Wenchao Xia
2013-12-03 7:43 ` Fam Zheng
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 2/6] qemu-iotests: Honour cache mode in iotests.py Fam Zheng
2013-12-03 5:35 ` Wenchao Xia
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes Fam Zheng
2013-12-03 6:05 ` Wenchao Xia
2013-12-03 8:21 ` Fam Zheng
2013-12-03 9:28 ` Kevin Wolf
2013-12-03 10:33 ` Fam Zheng [this message]
2013-12-03 9:19 ` Stefan Hajnoczi
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 4/6] qemu-iotests: Change default cache mode to "writeback" Fam Zheng
2013-12-03 6:28 ` Wenchao Xia
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 5/6] qemu-iotests: Clean up spaces in usage output Fam Zheng
2013-12-03 6:28 ` Wenchao Xia
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 6/6] qemu-iotests: Split qcow2 only cases in 048 Fam Zheng
2013-12-03 9:56 ` [Qemu-devel] [PATCH v4 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback" Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529DB35D.5070408@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).